[1.10.2] Item overrides not working

[XFactHD]

I have an item block which (for legacy reasons) stores its subtype in the stack's tag compound. For the item I have registered a custom IItemPropertyGetter:

private static class TypePropertyGetter implements IItemPropertyGetter
    {
        @Override
        public float apply(ItemStack stack, @Nullable World world, @Nullable EntityLivingBase entity)
        {
            if (stack.hasTagCompound())
            {
                return stack.getTagCompound().getInteger("type")-1;
            }
            return 0;
        }
    }

 

What proves that the stack actually has a tag compound and the correct data is that the item's tooltip shows the correct data. The items (except for the first type) however all get the item model of the second type.

This is the part of my model which controls the overrides:

"overrides": [
        {
            "predicate": {
                "type": 1
            },
            "model": "rfutilities:block/blockCapacitorHardened"
        },
        {
            "predicate": {
                "type": 2
            },
            "model": "rfutilities:block/blockCapacitorReinforced"
        },
        {
            "predicate": {
                "type": 3
            },
            "model": "rfutilities:block/blockCapacitorResonant"
        },
        {
            "predicate": {
                "type": 4
            },
            "model": "rfutilities:block/blockCapacitorBasic"
        },
        {
            "predicate": {
                "type": 5
            },
            "model": "rfutilities:block/blockCapacitorDouble"
        },
        {
            "predicate": {
                "type": 6
            },
            "model": "rfutilities:block/blockCapacitorOctadic"
        }
    ]

 

I also know for sure that the models are correct as the blocks use the same model and they each get the correct one.

[XFactHD]

The whole item block class:

package XFactHD.rfutilities.common.blocks.itemBlock;

import XFactHD.rfutilities.RFUtilities;
import XFactHD.rfutilities.common.blocks.block.BlockCapacitor;
import XFactHD.rfutilities.common.blocks.tileEntity.TileEntityCapacitor;
import XFactHD.rfutilities.common.utils.Reference;
import net.minecraft.block.state.IBlockState;
import net.minecraft.client.resources.I18n;
import net.minecraft.item.IItemPropertyGetter;
import net.minecraft.tileentity.TileEntity;
import net.minecraft.util.ResourceLocation;
import net.minecraft.util.text.TextFormatting;
import net.minecraftforge.fml.common.Loader;
import net.minecraft.block.Block;
import net.minecraft.creativetab.CreativeTabs;
import net.minecraft.entity.EntityLivingBase;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.item.Item;
import net.minecraft.item.ItemBlock;
import net.minecraft.item.ItemStack;
import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.util.math.BlockPos;
import net.minecraft.world.World;

import javax.annotation.Nullable;
import java.util.List;

@SuppressWarnings("unchecked")
public class ItemBlockRFCapacitor extends ItemBlock
{
    public ItemBlockRFCapacitor(Block b)
    {
        super(b);
        addPropertyOverride(new ResourceLocation("type"), new TypePropertyGetter());
    }

    @Override
    public boolean onBlockDestroyed(ItemStack stack, World world, IBlockState state, BlockPos pos, EntityLivingBase entity)
    {
        TileEntity te = world.getTileEntity(pos);
        if (entity instanceof EntityPlayer && block instanceof BlockCapacitor && te instanceof TileEntityCapacitor)
        {
            NBTTagCompound compound = new NBTTagCompound();
            compound.setInteger("type", ((TileEntityCapacitor)te).type);
            stack.setTagCompound(compound);
        }
        return super.onBlockDestroyed(stack, world, state, pos, entity);
    }

    @Override
    public void getSubItems(Item item, CreativeTabs tabs, List list)
    {
        ItemStack capTEBasic =      new ItemStack(item, 1, 0);
        ItemStack capTEHardened =   new ItemStack(item, 1, 0);
        ItemStack capTEReinforced = new ItemStack(item, 1, 0);
        ItemStack capTEResonant =   new ItemStack(item, 1, 0);
        ItemStack capEIOBasic =     new ItemStack(item, 1, 0);
        ItemStack capEIODouble =    new ItemStack(item, 1, 0);
        ItemStack capEIOVibrant =   new ItemStack(item, 1, 0);

        NBTTagCompound nbtTEBasic =      new NBTTagCompound();
        NBTTagCompound nbtTEHardened =   new NBTTagCompound();
        NBTTagCompound nbtTEReinforced = new NBTTagCompound();
        NBTTagCompound nbtTEResonant =   new NBTTagCompound();
        NBTTagCompound nbtEIOBasic =     new NBTTagCompound();
        NBTTagCompound nbtEIODouble =    new NBTTagCompound();
        NBTTagCompound nbtEIOVibrant =   new NBTTagCompound();

        nbtTEBasic.setInteger("type", 1);
        nbtTEHardened.setInteger("type", 2);
        nbtTEReinforced.setInteger("type", 3);
        nbtTEResonant.setInteger("type", 4);
        nbtEIOBasic.setInteger("type", 5);
        nbtEIODouble.setInteger("type", 6);
        nbtEIOVibrant.setInteger("type", 7);

        capTEBasic.setTagCompound(nbtTEBasic);
        capTEHardened.setTagCompound(nbtTEHardened);
        capTEReinforced.setTagCompound(nbtTEReinforced);
        capTEResonant.setTagCompound(nbtTEResonant);
        capEIOBasic.setTagCompound(nbtEIOBasic);
        capEIODouble.setTagCompound(nbtEIODouble);
        capEIOVibrant.setTagCompound(nbtEIOVibrant);

        list.add(capTEBasic);
        list.add(capTEHardened);
        list.add(capTEReinforced);
        list.add(capTEResonant);
        list.add(capEIOBasic);
        list.add(capEIODouble);
        list.add(capEIOVibrant);
    }

    @Override
    @SuppressWarnings("ConstantConditions")
    public void addInformation(ItemStack stack, EntityPlayer player, List list, boolean bool)
    {
        //FIXME: just a workaround for an issue with JEI
        if (!stack.hasTagCompound())
        {
            super.addInformation(stack, player, list, bool);
            return;
        }
        int type = stack.getTagCompound().getInteger("type");
        if (type < 5 && (!Loader.isModLoaded("ThermalExpansion") && !RFUtilities.devEnv))
        {
            String warn = I18n.format("desc.rfutilities:noDep.name");
            list.add(TextFormatting.RED + warn);
        }
        else if (type < 5)
        {
            String info = I18n.format("desc.rfutilities:capType.name");
            String typeName = I18n.format("desc.rfutilities:capType_" + type + ".name");
            list.add(info + " " + typeName);
        }
        if (type > 4 && (!Loader.isModLoaded("EnderIO") && !RFUtilities.devEnv))
        {
            String warn = I18n.format("desc.rfutilities:noDep.name");
            list.add(TextFormatting.RED + warn);
        }
        else if (type > 4)
        {
            String info = I18n.format("desc.rfutilities:capType.name");
            String typeName = I18n.format("desc.rfutilities:capType_" + type + ".name");
            list.add(info + " " + typeName);
        }
        super.addInformation(stack, player, list, bool);
    }

    private static class TypePropertyGetter implements IItemPropertyGetter
    {
        @Override
        public float apply(ItemStack stack, @Nullable World world, @Nullable EntityLivingBase entity)
        {
            if (stack.hasTagCompound())
            {
                return stack.getTagCompound().getInteger("type")-1;
            }
            return 0;
        }
    }
}

 

The block class:

package XFactHD.rfutilities.common.blocks.block;

import XFactHD.rfutilities.common.blocks.itemBlock.ItemBlockRFCapacitor;
import XFactHD.rfutilities.common.blocks.tileEntity.TileEntityCapacitor;
//import cofh.thermalexpansion.item.tool.ItemMultimeter;
import net.minecraft.block.material.Material;
import net.minecraft.block.properties.PropertyDirection;
import net.minecraft.block.properties.PropertyInteger;
import net.minecraft.block.state.BlockStateContainer;
import net.minecraft.block.state.IBlockState;
import net.minecraft.client.resources.I18n;
import net.minecraft.entity.EntityLivingBase;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.item.ItemStack;
import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.tileentity.TileEntity;
import net.minecraft.util.*;
import net.minecraft.util.math.BlockPos;
import net.minecraft.util.math.RayTraceResult;
import net.minecraft.util.text.TextComponentString;
import net.minecraft.world.IBlockAccess;
import net.minecraft.world.World;

import javax.annotation.Nullable;
import java.util.Arrays;

@SuppressWarnings("deprecation")
public class BlockCapacitor extends BlockBaseRFU
{
    public static PropertyDirection ORIENTATION = PropertyDirection.create("facing", Arrays.asList(EnumFacing.NORTH, EnumFacing.EAST, EnumFacing.SOUTH, EnumFacing.WEST));
    public static PropertyInteger TYPE = PropertyInteger.create("type", 1, 7);

    public BlockCapacitor()
    {
        super("blockCapacitor", Material.IRON, "");
        this.addItemBlock(new ItemBlockRFCapacitor(this));
    }

    @Override
    public IBlockState onBlockPlaced(World world, BlockPos pos, EnumFacing facing, float hitX, float hitY, float hitZ, int meta, EntityLivingBase placer)
    {
        return getDefaultState().withProperty(ORIENTATION, placer.getHorizontalFacing().getOpposite());
    }

    @Override
    public void onBlockPlacedBy(World world, BlockPos pos, IBlockState state, EntityLivingBase entity, ItemStack stack)
    {
        TileEntity te = world.getTileEntity(pos);
        if (entity instanceof EntityPlayer && te instanceof TileEntityCapacitor)
        {
            ((TileEntityCapacitor) te).type = stack.getTagCompound().getInteger("type");
            world.scheduleUpdate(pos, world.getBlockState(pos).getBlock(), 0);
            te.markDirty();

        }
    }

    @Override
    public boolean onBlockActivated(World world, BlockPos pos, IBlockState state, EntityPlayer player, EnumHand hand, @Nullable ItemStack heldItem, EnumFacing side, float hitX, float hitY, float hitZ)
    {
        TileEntity te = world.getTileEntity(pos);
        if (te instanceof TileEntityCapacitor && hand == EnumHand.MAIN_HAND /*&& player.getCurrentEquippedItem() != null && player.getCurrentEquippedItem().getItem() instanceof ItemMultimeter*/ && !world.isRemote)
        {
            player.addChatComponentMessage(new TextComponentString(I18n.format("desc.rfutilities:stored.name") + " " + ((TileEntityCapacitor)te).getEnergyStored(EnumFacing.DOWN) + " " + I18n.format("desc.rfutilities:rf.name") + " / " + ((TileEntityCapacitor)te).getMaxEnergyStored(EnumFacing.DOWN) + " " + I18n.format("desc.rfutilities:rf.name")));
            return true;
        }
        return false;
    }

    @Override
    protected BlockStateContainer createBlockState()
    {
        return new BlockStateContainer(this, ORIENTATION, TYPE);
    }

    @Override
    public IBlockState getStateFromMeta(int meta)
    {
        if (EnumFacing.getFront(meta) == EnumFacing.UP || EnumFacing.getFront(meta) == EnumFacing.DOWN)
        {
            return getDefaultState().withProperty(ORIENTATION, EnumFacing.NORTH);
        }
        return getDefaultState().withProperty(ORIENTATION, EnumFacing.getFront(meta));
    }

    @Override
    public int getMetaFromState(IBlockState state)
    {
        return state.getValue(ORIENTATION).getIndex();
    }

    @Override
    public IBlockState getActualState(IBlockState state, IBlockAccess world, BlockPos pos)
    {
        TileEntity te = world.getTileEntity(pos);
        int cap = 0;
        if (te instanceof TileEntityCapacitor)
        {
            cap = ((TileEntityCapacitor)te).type;
        }
        if (cap == 0)
        {
            return state.withProperty(TYPE, 1);
        }
        return state.withProperty(TYPE, cap);
    }

    @Override
    public ItemStack getPickBlock(IBlockState state, RayTraceResult target, World world, BlockPos pos, EntityPlayer player)
    {
        ItemStack stack = new ItemStack(this, 1, 0);
        NBTTagCompound compound = new NBTTagCompound();
        compound.setInteger("type", ((TileEntityCapacitor)world.getTileEntity(pos)).type);
        stack.setTagCompound(compound);
        return stack;
    }

    @Override
    public TileEntity createTileEntity(World world, IBlockState state)
    {
        return new TileEntityCapacitor();
    }

    @Override
    public boolean isOpaqueCube(IBlockState state)
    {
        return false;
    }
}

The addItemBlock method from the block base class:

    protected void addItemBlock(ItemBlock itemBlock)
    {
        itemBlock.setUnlocalizedName(this.getUnlocalizedName());
        itemBlock.setRegistryName(this.getRegistryName());
        GameRegistry.register(itemBlock);
    }

 

The registration method in the Content class:

     public static void preInit()
    {
        ...
        blockCapacitor = new BlockCapacitor();
        ...
    }

 

The model registration in the ClientProxy class:

    @Override
    public void preInit(FMLPreInitializationEvent event)
    {
        super.preInit(event);
        ModelLoader.setCustomModelResourceLocation(Item.getItemFromBlock(RFUContent.blockCapacitor), 0, new ModelResourceLocation(Reference.MOD_ID + ":blockCapacitor", "inventory"));
        ...
        }
    }

[XFactHD]

With a breakpoint on the return value in the if statement of the apply method of the IItemPropertyGetter I found that there is a pattern of 12 calls to this method with the value in the stackTagCompound being 1 for the first five calls and then the correct value for the next seven calls. The call stack is always the same. As I am checking for the stack having an NBTTagCompound, I know that those calls are only made for the items in the slots of the creative tab and not for the icon of the creative tab as that stack doesn't have NBT data.

[jeffryfisher]

"model": "rfutilities:block/blockCapacitorReinforced"

 

Are these models actually different? Did you copy-paste and forget to customize the copies?

[XFactHD]

The model that contains the overrides section is the parent of the other six models. The models used for the items are the same as the ones for the blocks (same json file) and the block models work as expected.

[jeffryfisher]

OK... you override getSubItems, but did you set hasSubtypes to true?

[yooksi]

OK... you override getSubItems, but did you set hasSubtypes to true?

From what he has shown us I would say no.

 

@XFactHD In order to get your subtypes to work and call

getSubItems

you have to call

setHasSubtypes(true)

from inside your

ItemBlockRFCapacitor

ItemBlock class constructor.

[XFactHD]

You are right, I most likely forgot that, I'll check if that fixes it.

[XFactHD]

I did really forget that, but it unfortunately doesn't fix my problem.

[yooksi]

I did really forget that, but it unfortunately doesn't fix my problem.

 

Did you set item max damage to 0, and are you changing item damage at any point in your code?

[XFactHD]

I did not set the max item damage to 0 and I also do not change the metadata at any point in my code, the only difference between these seven item blocks is the type value stored in the NBT tab of the itemstack.

[yooksi]

I did not set the max item damage to 0 and I also do not change the metadata at any point in my code, the only difference between these seven item blocks is the type value stored in the NBT tab of the itemstack.

 

The easiest solution would be to stop using NBT to store metadata, and use the local metadata value in Item for that, like it was meant to be used.

[XFactHD]

I can't really do that right now as it would break the mod for everyone currently using it but I couldtry to implement some kind of legacy code.