Jump to content

[1.10.2] [Scala] Get EntityPlayer from capability instance


tripl3dogdare

Recommended Posts

I'm working with the capability system for mana and custom levels/experience, and trying to expose custom Forge events for things like leveling up or your mana being full. However, as far as I can tell I either have to do this externally (not optimal) or have some way of getting or storing the player by capability instance. Any ideas on how to do this efficiently?

 

LevelHandler:

trait LevelHandlerLike {
var level,maxLevel:Int
var exp:Float
def expToNext = if(level >= maxLevel) 0 else Math.pow(level, 1.1).toFloat*100

def setLevel(lvl:Int) { level = lvl; updateLevelInfo }
def setExp(amt:Float) { exp = amt; updateLevelInfo }
def setMaxLevel(lvl:Int) = maxLevel = lvl
def addExp(amt:Float) = setExp(exp+amt)

def updateLevelInfo {
	if(level >= maxLevel) { exp = 0; return }

	if(exp >= expToNext) {
		exp -= expToNext
		setLevel(Math.min(level+1, maxLevel))
	}
}

def copyTo(lh:LevelHandlerLike) {
	lh.setMaxLevel(maxLevel)
	lh.setLevel(level)
	lh.setExp(exp)
}
}

class LevelHandler(var level:Int = 0, var exp:Float = 0, var maxLevel:Int = 0) extends LevelHandlerLike with ICapabilitySerializable[NBTTagCompound] {
private var dirty = true
private var lvupev = false

def shouldFireLevelUpEvent:Boolean = { val o = lvupev; lvupev = false; o }
private def updateDirty[T <% Float](bfr:T, aft:T, isLevel:Boolean=false) = if(bfr != aft) { dirty = true; if(isLevel) lvupev = true }

override def setLevel(lvl:Int) { val old = level; super.setLevel(lvl); updateDirty(old, level, true) }
override def setExp(amt:Float) { val old = exp; super.setExp(amt); updateDirty(old, exp) }
override def setMaxLevel(lvl:Int) { val old = maxLevel; super.setMaxLevel(lvl); updateDirty(old, maxLevel) }

def updateClient(player:EntityPlayer, force:Boolean=false) = 
	if(!player.worldObj.isRemote && (force || dirty)) { ChuuniMod.network.sendTo(new MessageUpdateClient(this), player.asInstanceOf[EntityPlayerMP]); dirty = false }

def hasCapability(capability:Capability[_], f:EnumFacing) = capability == Capabilities.LEVEL
def getCapability[T](capability:Capability[T], f:EnumFacing) = { if(capability == Capabilities.LEVEL) this else null }.asInstanceOf[T]

def serializeNBT:NBTTagCompound = {
	val nbt = new NBTTagCompound
	nbt.setInteger("level", level)
	nbt.setFloat("exp", exp)
	nbt.setInteger("maxLevel", maxLevel)
	nbt
}

def deserializeNBT(nbt:NBTTagCompound) = {
	setLevel(nbt.getInteger("level"))
	setExp(nbt.getFloat("exp"))
	setMaxLevel(nbt.getInteger("maxLevel"))
}
}

object LevelHandler {
def instanceFor(player:EntityPlayer) = player.getCapability(Capabilities.LEVEL, null)
def getHandlerInstance = new LevelHandler
def getStorageInstance = new LevelHandler.Storage
def getHandlerFactory = new Callable[LevelHandler] { def call = new LevelHandler }

class Storage extends IStorage[LevelHandler] {
	def writeNBT(cap:Capability[LevelHandler], ins:LevelHandler, f:EnumFacing) = ins.asInstanceOf[LevelHandler].serializeNBT
	def readNBT(cap:Capability[LevelHandler], ins:LevelHandler, f:EnumFacing, nbt:NBTBase) = ins.asInstanceOf[LevelHandler].deserializeNBT(nbt.asInstanceOf[NBTTagCompound])
}

class MessageUpdateClient(lh:LevelHandlerLike) extends IMessage with LevelHandlerLike {
	var level,maxLevel:Int = 0
	var exp:Float = 0
	if(lh != null) lh.copyTo(this)

	def this() = this(null)

	def fromBytes(buf:ByteBuf) { level = buf.readInt; exp = buf.readFloat; maxLevel = buf.readInt }
	def toBytes(buf:ByteBuf) { buf.writeInt(level); buf.writeFloat(exp); buf.writeInt(maxLevel) }
}

object MessageUpdateClient {
	class Handler extends IMessageHandler[MessageUpdateClient, IMessage] {
		def onMessage(msg:MessageUpdateClient, ctx:MessageContext):IMessage = {
			Minecraft.getMinecraft.addScheduledTask(new Runnable { def run = {
				val player = Minecraft.getMinecraft.thePlayer
				val lh = LevelHandler.instanceFor(player)

				msg.copyTo(lh)
			}})
			null
		}
	}

	def register(net:SimpleNetworkWrapper, id:Int) = net.registerMessage(classOf[MessageUpdateClient.Handler], classOf[MessageUpdateClient], id, Side.CLIENT)
}
}

 

You can see my hacky, sort-of-works way of doing it in LevelHandler.shouldFireLevelUpEvent and related.. but this relies on the EventHandler checking this any place that it updates the LevelHandler. Bleh.

 

I can handle the ManaHandler with the same concept once I get the LevelHandler exposed.

Link to comment
Share on other sites

Is there anything stopping you from storing EntityPlayer in field inside capability? Because that is the right way to do it. Capability doesn't really change owner (unless you want it to), so you basically can just put such field inside it and set it on capability creation (during attach event).

 

Other approach is to simply make it as passed arg, by putting EntityPlayer in all methods that use it and then pass it from callers side (so eg. from Forge Event), but this one is too much of a hassle.

1.7.10 is no longer supported by forge, you are on your own.

Link to comment
Share on other sites

The only real problem with that approach is that due to the auto-constructed nature of capabilities, that becomes a bit of a logistical pain in the backside. For example, the function for registering a capability takes a factory for them, in a context where I have no possible way to access the player.

 

I'll probably just end up making them a nulled optional argument... Not optimal either, but depending on how i play it I could get it to work (probably...)

Link to comment
Share on other sites

Except doing it that way would require two separate implementations - not very clean at all. Wouldn't null-checking be cleaner than that? I don't know, maybe that's just me being weird about how I code.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • i tried downloading the drivers but it says no AMD graphics hardware has been detected    
    • Update your AMD/ATI drivers - get the drivers from their website - do not update via system  
    • As the title says i keep on crashing on forge 1.20.1 even without any mods downloaded, i have the latest drivers (nvidia) and vanilla minecraft works perfectly fine for me logs: https://pastebin.com/5UR01yG9
    • Hello everyone, I'm making this post to seek help for my modded block, It's a special block called FrozenBlock supposed to take the place of an old block, then after a set amount of ticks, it's supposed to revert its Block State, Entity, data... to the old block like this :  The problem I have is that the system breaks when handling multi blocks (I tried some fix but none of them worked) :  The bug I have identified is that the function "setOldBlockFields" in the item's "setFrozenBlock" function gets called once for the 1st block of multiblock getting frozen (as it should), but gets called a second time BEFORE creating the first FrozenBlock with the data of the 1st block, hence giving the same data to the two FrozenBlock :   Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=head] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@73681674 BlockEntityData : id:"minecraft:bed",x:3,y:-60,z:-6} Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=3, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=2, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} here is the code inside my custom "freeze" item :    @Override     public @NotNull InteractionResult useOn(@NotNull UseOnContext pContext) {         if (!pContext.getLevel().isClientSide() && pContext.getHand() == InteractionHand.MAIN_HAND) {             BlockPos blockPos = pContext.getClickedPos();             BlockPos secondBlockPos = getMultiblockPos(blockPos, pContext.getLevel().getBlockState(blockPos));             if (secondBlockPos != null) {                 createFrozenBlock(pContext, secondBlockPos);             }             createFrozenBlock(pContext, blockPos);             return InteractionResult.SUCCESS;         }         return super.useOn(pContext);     }     public static void createFrozenBlock(UseOnContext pContext, BlockPos blockPos) {         BlockState oldState = pContext.getLevel().getBlockState(blockPos);         BlockEntity oldBlockEntity = oldState.hasBlockEntity() ? pContext.getLevel().getBlockEntity(blockPos) : null;         CompoundTag oldBlockEntityData = oldState.hasBlockEntity() ? oldBlockEntity.serializeNBT() : null;         if (oldBlockEntity != null) {             pContext.getLevel().removeBlockEntity(blockPos);         }         BlockState FrozenBlock = setFrozenBlock(oldState, oldBlockEntity, oldBlockEntityData);         pContext.getLevel().setBlockAndUpdate(blockPos, FrozenBlock);     }     public static BlockState setFrozenBlock(BlockState blockState, @Nullable BlockEntity blockEntity, @Nullable CompoundTag blockEntityData) {         BlockState FrozenBlock = BlockRegister.FROZEN_BLOCK.get().defaultBlockState();         ((FrozenBlock) FrozenBlock.getBlock()).setOldBlockFields(blockState, blockEntity, blockEntityData);         return FrozenBlock;     }  
    • It is an issue with quark - update it to this build: https://www.curseforge.com/minecraft/mc-mods/quark/files/3642325
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.