Jump to content

[1.10.2][SOLVED] Teleport to the players spawn point


MCrafterzz

Recommended Posts

I want players to teleport to there spawn point this is the code I've use (it crashes with a null Point exception):

 

@Override

public void onEntityCollidedWithBlock(World worldIn, BlockPos pos, IBlockState state, Entity entityIn) {

if (entityIn instanceof EntityLivingBase) {

EntityPlayer player = (EntityPlayer) entityIn;

entityIn.setPosition(player.getBedSpawnLocation(worldIn, player.getBedLocation(), false).getX(),

player.getBedSpawnLocation(worldIn, player.getBedLocation(), false).getY(),

player.getBedSpawnLocation(worldIn, player.getBedLocation(), false).getZ());

entityIn.playSound(SoundEvents.ENTITY_ENDERPEARL_THROW, 0.5f, 0.5f);

worldIn.spawnParticle(EnumParticleTypes.PORTAL, entityIn.getPosition().getX(),

entityIn.getPosition().getY(), entityIn.getPosition().getZ(), 0, 0, 10, 0);

}

}

Link to comment
Share on other sites

  • Replies 77
  • Created
  • Last Reply

Top Posters In This Topic

You create an instance of EntityPlayer, but you check if the Entity is an instanceof EntityLivingBase...

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Link to comment
Share on other sites

Updated code:

@Override

public void onEntityCollidedWithBlock(World worldIn, BlockPos pos, IBlockState state, Entity entityIn) {

if (entityIn instanceof EntityLivingBase) {

if (entityIn instanceof EntityPlayer) {

EntityPlayer player = (EntityPlayer) entityIn;

BlockPos spawnPosition = player.getBedLocation();

entityIn.setPosition(spawnPosition.getX(), spawnPosition.getY(), spawnPosition.getZ());

entityIn.playSound(SoundEvents.ENTITY_ENDERPEARL_THROW, 0.5f, 0.5f);

worldIn.spawnParticle(EnumParticleTypes.PORTAL, entityIn.getPosition().getX(),

entityIn.getPosition().getY(), entityIn.getPosition().getZ(), 0, 0, 10, 0);

} else {

entityIn.setPosition(worldIn.getSpawnPoint().getX(), worldIn.getSpawnPoint().getY(),

worldIn.getSpawnPoint().getZ());

}

}

}

Link to comment
Share on other sites

You create an instance of EntityPlayer, but you check if the Entity is an instanceof EntityLivingBase...

 

While this is true it wouldn't produce NPE, but CCE.

 

Question is - what is null there? My bet is on #getBedSpawnLocation. Also - this method might be called on both sides - it is worth checking that and place proper server side-check if that is a case (maybe its null on client and present on server and client is crashing?).

 

If you can't figure it out - please say at which line it crashes.

1.7.10 is no longer supported by forge, you are on your own.

Link to comment
Share on other sites

Changed to:

@Override

@SideOnly(Side.SERVER)

public void onEntityCollidedWithBlock(World worldIn, BlockPos pos, IBlockState state, Entity entityIn) {

if (entityIn instanceof EntityLivingBase) {

if (entityIn instanceof EntityPlayer) {

EntityPlayer player = (EntityPlayer) entityIn;

BlockPos spawnPosition = player.getBedLocation();

entityIn.setPosition(spawnPosition.getX(), spawnPosition.getY(), spawnPosition.getZ());

entityIn.playSound(SoundEvents.ENTITY_ENDERPEARL_THROW, 0.5f, 0.5f);

worldIn.spawnParticle(EnumParticleTypes.PORTAL, entityIn.getPosition().getX(),

entityIn.getPosition().getY(), entityIn.getPosition().getZ(), 0, 0, 10, 0);

} else {

entityIn.setPosition(worldIn.getSpawnPoint().getX(), worldIn.getSpawnPoint().getY(),

worldIn.getSpawnPoint().getZ());

}

}

}

Link to comment
Share on other sites

What if this code is going to be run in a SinglePlayer world wouldn't it crash because the method doesn't exist

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Link to comment
Share on other sites

Are you talking about in the case of

@SideOnly

?

If so: no, because the method is never directly referred to, Minecraft only refers to the overridden method (the one in Block). It would simply not work in SinglePlayer.

If not: Please clarify.

Well you were correct so it won't crash, but it won't work. That just changes the reason to not use it. Unless the OP wants it to only work on a dedicated server.

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Link to comment
Share on other sites

This is how the codes looks like now:

@Override

public void onEntityCollidedWithBlock(World worldIn, BlockPos pos, IBlockState state, Entity entityIn) {

if (!worldIn.isRemote) {

if (entityIn instanceof EntityLivingBase) {

if (entityIn instanceof EntityPlayer) {

EntityPlayer player = (EntityPlayer) entityIn;

BlockPos spawnPosition = player.getBedLocation();

entityIn.setPosition(spawnPosition.getX(), spawnPosition.getY(), spawnPosition.getZ());

entityIn.playSound(SoundEvents.ENTITY_ENDERPEARL_THROW, 0.5f, 0.5f);

worldIn.spawnParticle(EnumParticleTypes.PORTAL, entityIn.getPosition().getX(),

entityIn.getPosition().getY(), entityIn.getPosition().getZ(), 0, 0, 10, 0);

} else {

entityIn.setPosition(worldIn.getSpawnPoint().getX(), worldIn.getSpawnPoint().getY(),

worldIn.getSpawnPoint().getZ());

entityIn.playSound(SoundEvents.ENTITY_ENDERPEARL_THROW, 0.5f, 0.5f);

worldIn.spawnParticle(EnumParticleTypes.PORTAL, entityIn.getPosition().getX(),

entityIn.getPosition().getY(), entityIn.getPosition().getZ(), 0, 0, 10, 0);

}

}

}

}

Link to comment
Share on other sites

Yes,

@SideOnly

should not be used (unless you really know what you are doing). Which is why I linked both an article called "Why not to use

@SideOnly

" and a tutorial about the concept of sides in Minecraft.

Yes I understood what they do, but once I get some sleep and my brain is working "better" than it is currently I will read all of what you posted to understand it better. Thank you again diesieben.

 

This is how the codes looks like now:

@Override
public void onEntityCollidedWithBlock(World worldIn, BlockPos pos, IBlockState state, Entity entityIn) {
	if (!worldIn.isRemote) {
		if (entityIn instanceof EntityLivingBase) {
			if (entityIn instanceof EntityPlayer) {
				EntityPlayer player = (EntityPlayer) entityIn;
				BlockPos spawnPosition = player.getBedLocation();
				entityIn.setPosition(spawnPosition.getX(), spawnPosition.getY(), spawnPosition.getZ());
				entityIn.playSound(SoundEvents.ENTITY_ENDERPEARL_THROW, 0.5f, 0.5f);
				worldIn.spawnParticle(EnumParticleTypes.PORTAL, entityIn.getPosition().getX(),
						entityIn.getPosition().getY(), entityIn.getPosition().getZ(), 0, 0, 10, 0);
			} else {
				entityIn.setPosition(worldIn.getSpawnPoint().getX(), worldIn.getSpawnPoint().getY(),
						worldIn.getSpawnPoint().getZ());
				entityIn.playSound(SoundEvents.ENTITY_ENDERPEARL_THROW, 0.5f, 0.5f);
				worldIn.spawnParticle(EnumParticleTypes.PORTAL, entityIn.getPosition().getX(),
						entityIn.getPosition().getY(), entityIn.getPosition().getZ(), 0, 0, 10, 0);
			}
		}
	}
}

Can I assume it is still not working? Also if your code for the TeleportCommand is not "readable" then you should update forge to its most recent version and see if it is readable then.

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Link to comment
Share on other sites

I have removed one of the instanceof checks:

@Override

public void onEntityCollidedWithBlock(World worldIn, BlockPos pos, IBlockState state, Entity entityIn) {

if (!worldIn.isRemote) {

if (entityIn instanceof EntityPlayer) {

EntityPlayer player = (EntityPlayer) entityIn;

BlockPos spawnPosition = player.getBedLocation();

entityIn.setPosition(spawnPosition.getX(), spawnPosition.getY(), spawnPosition.getZ());

entityIn.playSound(SoundEvents.ENTITY_ENDERPEARL_THROW, 0.5f, 0.5f);

worldIn.spawnParticle(EnumParticleTypes.PORTAL, entityIn.getPosition().getX(),

entityIn.getPosition().getY(), entityIn.getPosition().getZ(), 0, 0, 10, 0);

} else {

entityIn.setPosition(worldIn.getSpawnPoint().getX(), worldIn.getSpawnPoint().getY(),

worldIn.getSpawnPoint().getZ());

entityIn.playSound(SoundEvents.ENTITY_ENDERPEARL_THROW, 0.5f, 0.5f);

worldIn.spawnParticle(EnumParticleTypes.PORTAL, entityIn.getPosition().getX(),

entityIn.getPosition().getY(), entityIn.getPosition().getZ(), 0, 0, 10, 0);

}

}

}

 

But I still don't know how to use the commandteleport code

Link to comment
Share on other sites

Changed it to this:

@Override

public void onEntityCollidedWithBlock(World worldIn, BlockPos pos, IBlockState state, Entity entityIn) {

if (!worldIn.isRemote) {

if (entityIn instanceof EntityPlayer) {

EntityPlayer player = (EntityPlayer) entityIn;

BlockPos spawnPosition = player.getBedLocation();

((EntityPlayerMP) entityIn).connection.setPlayerLocation(spawnPosition.getX(), spawnPosition.getY(),

spawnPosition.getZ(), player.getRotationYawHead(), player.getRotationYawHead());

entityIn.playSound(SoundEvents.ENTITY_ENDERPEARL_THROW, 0.5f, 0.5f);

worldIn.spawnParticle(EnumParticleTypes.PORTAL, entityIn.getPosition().getX(),

entityIn.getPosition().getY(), entityIn.getPosition().getZ(), 0, 0, 10, 0);

} else {

((EntityPlayerMP) entityIn).connection.setPlayerLocation(worldIn.getSpawnPoint().getX(),

worldIn.getSpawnPoint().getY(), worldIn.getSpawnPoint().getZ(), entityIn.getRotationYawHead(),

entityIn.getRotationYawHead());

entityIn.playSound(SoundEvents.ENTITY_ENDERPEARL_THROW, 0.5f, 0.5f);

worldIn.spawnParticle(EnumParticleTypes.PORTAL, entityIn.getPosition().getX(),

entityIn.getPosition().getY(), entityIn.getPosition().getZ(), 0, 0, 10, 0);

}

}

}

 

Testing now

Link to comment
Share on other sites

New error:

http://pastebin.com/TTrPzcdC

 

Line 39(errored line):

((EntityPlayerMP) entityIn).connection.setPlayerLocation(worldIn.getSpawnPoint().getX(),

worldIn.getSpawnPoint().getY(), worldIn.getSpawnPoint().getZ(), entityIn.getRotationYawHead(),

entityIn.getRotationYawHead());

Link to comment
Share on other sites

Why are you casting the entity to an EntityPlayer if it is not an instanceof EntityPlayer

((EntityPlayerMP) entityIn).connection.setPlayerLocation(worldIn.getSpawnPoint().getX(),
                  worldIn.getSpawnPoint().getY(), worldIn.getSpawnPoint().getZ(), entityIn.getRotationYawHead(),
                  entityIn.getRotationYawHead());
            entityIn.playSound(SoundEvents.ENTITY_ENDERPEARL_THROW, 0.5f, 0.5f);
            worldIn.spawnParticle(EnumParticleTypes.PORTAL, entityIn.getPosition().getX(),
                  entityIn.getPosition().getY(), entityIn.getPosition().getZ(), 0, 0, 10, 0);
         }

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Link to comment
Share on other sites

So the way you have it set for the player will work however as far as I can tell onEntityCollidedWithBlock doesn't get called for Item Entities.

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements




  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Hello everyone, I'm making this post to seek help for my modded block, It's a special block called FrozenBlock supposed to take the place of an old block, then after a set amount of ticks, it's supposed to revert its Block State, Entity, data... to the old block like this :  The problem I have is that the system breaks when handling multi blocks (I tried some fix but none of them worked) :  The bug I have identified is that the function "setOldBlockFields" in the item's "setFrozenBlock" function gets called once for the 1st block of multiblock getting frozen (as it should), but gets called a second time BEFORE creating the first FrozenBlock with the data of the 1st block, hence giving the same data to the two FrozenBlock :   Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=head] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@73681674 BlockEntityData : id:"minecraft:bed",x:3,y:-60,z:-6} Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=3, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=2, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} here is the code inside my custom "freeze" item :    @Override     public @NotNull InteractionResult useOn(@NotNull UseOnContext pContext) {         if (!pContext.getLevel().isClientSide() && pContext.getHand() == InteractionHand.MAIN_HAND) {             BlockPos blockPos = pContext.getClickedPos();             BlockPos secondBlockPos = getMultiblockPos(blockPos, pContext.getLevel().getBlockState(blockPos));             if (secondBlockPos != null) {                 createFrozenBlock(pContext, secondBlockPos);             }             createFrozenBlock(pContext, blockPos);             return InteractionResult.SUCCESS;         }         return super.useOn(pContext);     }     public static void createFrozenBlock(UseOnContext pContext, BlockPos blockPos) {         BlockState oldState = pContext.getLevel().getBlockState(blockPos);         BlockEntity oldBlockEntity = oldState.hasBlockEntity() ? pContext.getLevel().getBlockEntity(blockPos) : null;         CompoundTag oldBlockEntityData = oldState.hasBlockEntity() ? oldBlockEntity.serializeNBT() : null;         if (oldBlockEntity != null) {             pContext.getLevel().removeBlockEntity(blockPos);         }         BlockState FrozenBlock = setFrozenBlock(oldState, oldBlockEntity, oldBlockEntityData);         pContext.getLevel().setBlockAndUpdate(blockPos, FrozenBlock);     }     public static BlockState setFrozenBlock(BlockState blockState, @Nullable BlockEntity blockEntity, @Nullable CompoundTag blockEntityData) {         BlockState FrozenBlock = BlockRegister.FROZEN_BLOCK.get().defaultBlockState();         ((FrozenBlock) FrozenBlock.getBlock()).setOldBlockFields(blockState, blockEntity, blockEntityData);         return FrozenBlock;     }  
    • It is an issue with quark - update it to this build: https://www.curseforge.com/minecraft/mc-mods/quark/files/3642325
    • Remove Instant Massive Structures Mod from your server     Add new crash-reports with sites like https://paste.ee/  
    • Update your drivers: https://www.amd.com/en/support/graphics/amd-radeon-r9-series/amd-radeon-r9-200-series/amd-radeon-r9-280x
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.