[1.7.10] onPlayerStoppedUsing not running

[Sythiex]

I have an item with NBT data that I want to be reset to 0 when the player releases the right mouse button, but I can't figure out why onPlayerStoppedUsing() isn't being called. I'm probably overlooking something simple, here's the code:

 

public void onPlayerStoppedUsing(ItemStack itemStack, World world, EntityPlayer player, int ticks)
    {
	System.out.println("working");
	itemStack.stackTagCompound.setInteger("castTime", 0);
    }

public ItemStack onItemRightClick(ItemStack itemStack, World world, EntityPlayer player)
    {
	if(!world.isRemote)
	{
		ChunkCoordinates coords = player.getBedLocation(player.dimension);
		if(coords != null)
		{
			if(itemStack.stackTagCompound.getInteger("cooldown") == 0)
			{
				player.setItemInUse(itemStack, getMaxItemUseDuration(itemStack));
				if(itemStack.stackTagCompound.getInteger("castTime") >= maxCastTime)
				{
					player.setPositionAndUpdate(coords.posX + .5, coords.posY + 1, coords.posZ + .5);
					itemStack.stackTagCompound.setInteger("cooldown", maxCooldown);
					itemStack.stackTagCompound.setInteger("castTime", 0);
				}
				else
				{
					int timeCast = itemStack.stackTagCompound.getInteger("castTime") + 1;
					itemStack.stackTagCompound.setInteger("castTime", timeCast);
				}
			}
			return itemStack;
		}
		else
		{
			player.addChatMessage(new ChatComponentTranslation("msg.hearthstoneFailed.txt"));
			return itemStack;
		}
	}
	else
		return itemStack;
    }

public int getMaxItemUseDuration(ItemStack itemStack)
    {
        return 100;
    }

[Abastro]

Try adding @Override on onPlayerStoppedUsing method, to check if it overrides the correct method on item.

[Sythiex]

I tried that, but I didn't notice any changes so I took it back out. Thanks anyway

[deadrecon98]

I have an item with NBT data that I want to be reset to 0 when the player releases the right mouse button, but I can't figure out why onPlayerStoppedUsing() isn't being called. I'm probably overlooking something simple, here's the code:

 

public void onPlayerStoppedUsing(ItemStack itemStack, World world, EntityPlayer player, int ticks)
    {
	System.out.println("working");
	itemStack.stackTagCompound.setInteger("castTime", 0);
    }

public ItemStack onItemRightClick(ItemStack itemStack, World world, EntityPlayer player)
    {
	if(!world.isRemote)
	{
		ChunkCoordinates coords = player.getBedLocation(player.dimension);
		if(coords != null)
		{
			if(itemStack.stackTagCompound.getInteger("cooldown") == 0)
			{
				player.setItemInUse(itemStack, getMaxItemUseDuration(itemStack));
				if(itemStack.stackTagCompound.getInteger("castTime") >= maxCastTime)
				{
					player.setPositionAndUpdate(coords.posX + .5, coords.posY + 1, coords.posZ + .5);
					itemStack.stackTagCompound.setInteger("cooldown", maxCooldown);
					itemStack.stackTagCompound.setInteger("castTime", 0);
				}
				else
				{
					int timeCast = itemStack.stackTagCompound.getInteger("castTime") + 1;
					itemStack.stackTagCompound.setInteger("castTime", timeCast);
				}
			}
			return itemStack;
		}
		else
		{
			player.addChatMessage(new ChatComponentTranslation("msg.hearthstoneFailed.txt"));
			return itemStack;
		}
	}
	else
		return itemStack;
    }

public int getMaxItemUseDuration(ItemStack itemStack)
    {
        return 100;
    }

 

1.Every function you are overriding (right click, etc) must have @Override above it in order for it to be called.

2.Have you looked the code for ItemBow?

[Anon10W1z]

What are you saying deadrecon? You don't need @Override, it just helps.

[deadrecon98]

What are you saying deadrecon? You don't need @Override, it just helps.

 

I thought that @Override specified that you were overriding a parent method. Otherwise it would just be a regular method called only if you did it manually.

[Anon10W1z]

The way it's used is to check if it overrides a method. If a method does not override another, but it has the annotation, it won't compile.

[Sythiex]

1.Every function you are overriding (right click, etc) must have @Override above it in order for it to be called.

2.Have you looked the code for ItemBow?

 

I have tried putting @Override on just about everything, but it neither fixes the issue nor breaks my code, so I left them out. And I did read through ItemBow, but I didn't see anything I was missing.

[Abastro]

Of course it has no effect.. @Override is just a check. And if it doesnt give any errors, then it is fine.

+ does "working" not get printed?

[Sythiex]

Of course it has no effect.. @Override is just a check. And if it doesnt give any errors, then it is fine.

+ does "working" not get printed?

 

"working" does not get printed