Bektor

Hi, I'm wondering what things I can test with JUnit 5 of my mod as I know that Minecraft is a bit limited in terms of what can be tested and what can't. Thx in advance. Bektor

Hi, I'm wondering how I can change mod mappings in order to convert some changed block names over to the new names as I'm currently refactoring my complete src code like every few months and don't want to re-create my entire test world again. Thx in advance. Bektor

Hi there, I want to know wether it is possible to use the new plugins { id 'java' id 'eclipse' id 'idea' } syntax for the net.minecraftforge.gradle:ForgeGradle:2.3-SNAPSHOT plugin, as it seems to be that there are multiply different types of plugins with different requirements for this syntax: https://docs.gradle.org/current/userguide/plugins.html I don't know when this new sytanx was added, but I'm currently upgrading to Gradle 4.6 because of it's native JUnit 5 support. Thx in advance. Bektor

This makes me wonder why those classes are still around in Java. I've used them since I started with Java in Java 7 times.

Hi, I've got a problem that I want to save some copied files with my Minecraft Mod, but I want this to be handled on an extra thread. The problem is that I'm getting up to 5 temp files which contain my files instead of 1 zip file. public synchronized void start(Path path) { // Set the path here as it might have changed before the thread starts the backup process this.directory = path.resolve("tests.zip"); this.thread = new Thread(this, "World Backup Thread"); this.thread.setPriority(7); this.thread.start(); } public synchronized void stop() { try { this.thread.join(); } catch (InterruptedException e) { ServerUtilities.LOGGER.fatal(e); } } @Override public void run() { if(!this.isDone) this.createZipFile(); this.isDone = true; // at ThreadBackups.run(ThreadBackups.java:56) } private void createZipFile() { ImmutableMap immutableMap = ImmutableMap.of("create", String.valueOf(Files.notExists(this.directory))); FileSystemProvider zipProvider = FileSystemProvider.installedProviders().stream() .filter(provider -> provider.getScheme().equals("jar")).findFirst().get(); try(FileSystem fs = zipProvider.newFileSystem(this.directory, immutableMap)) { Path root = fs.getPath("/"); // this.world = path to the worldPath on which saving was disabled beforehand using world.disableLevelSaving = true; Files.walk(this.worldPath).forEach((Path sourcePath) -> { try { Path destination = root; for(Path p : this.worldPath.relativize(sourcePath)) destination = destination.resolve(p.toString()); if(!Files.isDirectory(destination) || !Files.isDirectory(sourcePath)) Files.copy(sourcePath, destination); } catch(IOException e) { e.printStackTrace(); } }); } catch(IOException e) { e.printStackTrace(); } // ThreadBackups.createZipFile(ThreadBackups.java:81) } // within TickEvent.ServerTickEvent [...] // disables all level saving and then calls the thread to start! Backups.INSTANCE.start(Backups.INSTANCE.server, ""); // returns the isDone value from the thread to which this class holds no reference as the Backups class created it if(Backups.INSTANCE.isDone()) { Backups.INSTANCE.stop(); // stops the whole thread by only calling the stop method in the thread class timeTillBackup = ModConfig.Backup.timeTillBackup; } [...] It also causes and AccessDeniedException for the zip file to be created as it can't find the zip file, thus causing a NoSuchFileException after the first exception. Backups is not the class shown here! Backups holds an instance to the thread and calls the start/stop methods in the thread class which are posted here like the thread itself. The start method in Backups disables level saving and calls afterwards the start method of the thread to start the backup process. The stop method of Backups does nothing but to call the stop of the thread itself while isDone returns the boolean isDone from the thread. This means the thread itself does nothing more as to create the files. All other logic is handles in other classes. Exceptions: I should note that I also tested if it is possible to write ZIP files within a thread and that just works fine, thought in Minecraft it doesn't. Thx in advance. Bektor

@diesieben07 Thx for the help so far with this problem. Guess this had solved the problem. Path zipRoot = fs.getPath("/");

Hm.. I'm wondering: When using FileSystemProvider etc. how should I add files to a ZIP file and is it possible to set the compression level? // this.world = DimensionManager.getCurrentSaveRootDirectory().toPath(); // fs = FileSystem try { Files.walk(this.world).filter(path -> !Files.isDirectory(path)) .forEach((Path path) -> { try { Files.copy(this.world.resolve(path), fs.getPath(path.toString()), StandardCopyOption.REPLACE_EXISTING); } catch (IOException e) { e.printStackTrace(); } }); } catch (IOException e) { e.printStackTrace(); // TODO: use logger } Guess it's much easier to just buy some 4TB hard drive then creating a ZIP file in Java. ^^

I guess someone should take the time to rewrite the whole ZIP API. ^^ Thought it is quite interesting how people go about using ZipEntry and others go with Files.copy while others do it completly different.

Hm.. Wouldn't it make much more sense to just use Files.createFile? I mean, I don't see any benefit of using these two lines if one line of code could do the same? What would be the benefits of using your approach vs Files.createFile?? And why do I have to use the argumentjar there instead of zip?

Oh... guess it wasn't that great of an idea to start programming late in the evening... ^^ // it is the same path as from the posts before, just in the backup thread which is located in another class, so I'm storing within the // thread a local reference/variable this.directionary = path; this.directionary.resolve("test.zip"); // changed to this: this.directionary = path.resolve("test.zip"); Thought even when changing this the error still occurs:

Meaning that resolve doesn't work for combining a path with a file? How am I to create this path then using my already existing path?

My path ends with a .zip as can be seen in my previous posts. And I basically want to create a new zip file and copy the whole world into it.

How would I go about creating it then? I never worked with zip files and not much with file systems before, so I just read the docs here: https://docs.oracle.com/javase/8/docs/technotes/guides/io/fsp/zipfilesystemprovider.html

// it is the same path as from the posts before, just in the backup thread which is located in another class, so I'm storing within the // thread a local reference/variable this.directionary = path; this.directionary.resolve("test.zip"); [...] private void createZipFile() { // Delete the file if it already exists try { if(Files.deleteIfExists(this.directionary)) ServerUtilities.LOGGER.info("Deleted file '" + this.directionary.getFileName().toString() + "'."); } catch (IOException e) { ServerUtilities.LOGGER.fatal("Tried to delete an old backup, but failed. Backup: " + this.directionary.getFileName().toString(), e); } try(FileSystem zipFile = FileSystems.newFileSystem(this.directionary, null)) { Files.copy(this.world, this.directionary, StandardCopyOption.REPLACE_EXISTING); } catch(IOException e) { } }

If I leave the dot where it is the whole code will run into an exception at the first try to create a file within my backups directionary as it does not exist because windows doesn't permit a directory with a dot within its name. (Thought the code to create the directory doesn't throw the exception, the one who tries to create a file within the directiory does however.) Interestingly enough it is an FileSystemNotFoundException while the backups directory in which it tries to write doesn't even exist. try(FileSystem zipFile = FileSystems.newFileSystem(this.path.resolve("test.zip", null)) {