Jump to content

MrDireball

Members
  • Posts

    34
  • Joined

  • Last visited

Posts posted by MrDireball

  1. While looking at the code in EntityVillager, I found something that has caught my eye. In the canVillagerPickupItem method, rather than loop through a static array of items that it can pick up, it uses an if-statement with six ||s. The problem with this is that whatever the villager is allowed to pick up is hardcoded into the statement. With an array, you could just go to where the array is initialized and add it in. Is there any particular way why it was done like this? I know that the final result is still the same, but you could say that about pretty much any good or bad practice.

     

        private boolean canVillagerPickupItem(Item itemIn)
        {
            return itemIn == Items.BREAD || itemIn == Items.POTATO || itemIn == Items.CARROT || itemIn == Items.WHEAT || itemIn == Items.WHEAT_SEEDS || itemIn == Items.BEETROOT || itemIn == Items.BEETROOT_SEEDS;
        }

     

  2. On 1/14/2019 at 11:26 AM, jabelar said:

    Your IDE should allow you to see all fields and methods for a class. In Eclipse it is called the Type Hierarchy. Just right-click on the class in the project hierarchy pane and select Type Hierarchy. There are a couple of "buttons" that affect the filtering of the view, I like to show everything including the inherited methods.

     

    That is a better way to scan for available methods than simply scrolling through class files themselves.

     

    In modding it is especially useful to look at the Type Hierarchy because you can actually get a lot of ideas for modding after you see some of the available methods, and at least get a really good feel for how the interfaces are organized.

    I wasn't actually looking through the code for the method, I made a variable for EntityAnimal and then typed the variable with a dot at the end and looked at all the suggestions.

  3. On 1/11/2019 at 6:49 AM, desht said:

    Tile entity registration needs to be done on both client and server, so why are you even using a proxy??  While we're at it, "CommonProxy" is an anti-pattern you should get rid of. The whole point of proxies is to implement different behaviour on the client and server; if the same code needs to be executed, then it shouldn't be in a proxy at all. The correct way to do this is to create an IProxy interface, and two implementations: a ClientProxy for the client and ServerProxy for the server. Pass those classnames to your @SidedProxy annotation, and define your proxy object with type IProxy.

     

    As for your tile entities, just register them from your FMLPreInitializationEvent handler.

    I just learned both Java and how to mod Minecraft a few days ago, so I don't actually know what a proxy is. I was just told somewhere to register TileEntities in a proxy.

  4. 32 minutes ago, unassigned said:

    You can use NBTagCompound#getCompoundTag instead of NBTTagCompound#getTag

     

    Aswell, are you sure that the itemStack field is not null? Are you assigning it anywhere? 

    Ah, yes, I forgot to check whether it was null first. I also fixed the other error by setting itemStack to initialize to a stack of air rather than null. So although there doesn't seem to be any more errors, the problem with it not saving the value of itemStack after unloading and reloading still persists.

     

    DataBlock

    Spoiler
    
    public class DataBlock extends BlockBase implements ITileEntityProvider {
    
        public static final PropertyDirection FACING = PropertyDirection.create("facing", EnumFacing.Plane.HORIZONTAL);
    
        public DataBlock() {
            super("data_block", Material.ROCK);
    		setCreativeTab(CreativeTabs.BUILDING_BLOCKS);
        }
    
        @SideOnly(Side.CLIENT)
        public void initModel() {
        	ModelLoader.setCustomModelResourceLocation(Item.getItemFromBlock(this), 0, new ModelResourceLocation(getRegistryName(), "inventory"));
        }
    
        @Override
        public TileEntity createNewTileEntity(World worldIn, int meta) {
            return new DataTileEntity();
        }
    
        private DataTileEntity getTE(World world, BlockPos pos) {
            return (DataTileEntity) world.getTileEntity(pos);
        }
    
        @Override
        public boolean onBlockActivated(World world, BlockPos pos, IBlockState state, EntityPlayer player, EnumHand hand,
                    EnumFacing side, float hitX, float hitY, float hitZ) {
            if (!world.isRemote) {
        		DataTileEntity dataEntity = (DataTileEntity)getTE(world, pos);
        	    ItemStack itemStack = dataEntity.getItemStack();
        	    dataEntity.setItemStack(player.getHeldItemMainhand());
        	    player.setHeldItem(player.getActiveHand(), itemStack);
            }
            return true;
        }
    
        @Override
        public void onBlockPlacedBy(World world, BlockPos pos, IBlockState state, EntityLivingBase placer, ItemStack stack) {
            world.setBlockState(pos, state.withProperty(FACING, placer.getHorizontalFacing().getOpposite()), 2);
        }
    
        @Override
        public IBlockState getStateFromMeta(int meta) {
            return getDefaultState().withProperty(FACING, EnumFacing.getFront((meta & 3) + 2));
        }
    
        @Override
        public int getMetaFromState(IBlockState state) {
            return state.getValue(FACING).getIndex()-2;
        }
    
        @Override
        protected BlockStateContainer createBlockState() {
            return new BlockStateContainer(this, FACING);
        }

     

    DataTileEntity

    Spoiler
    
    
    public class DataTileEntity extends TileEntity {
        
        ItemStack itemStack = new ItemStack(Items.AIR);
    
        public void setItemStack(ItemStack itemStack)
        {
            this.itemStack = itemStack;
            markDirty();
        }
        
        public ItemStack getItemStack() {
            return itemStack;
        }
    
        @Override
        public void readFromNBT(NBTTagCompound compound)
        {
        	super.readFromNBT(compound);
            if (compound.hasKey("item"))
            {
                itemStack.deserializeNBT((NBTTagCompound) compound.getCompoundTag("item"));
            }
        }
    
        @Override
        public NBTTagCompound writeToNBT(NBTTagCompound compound)
        {
            super.writeToNBT(compound);
            if (itemStack != null)compound.setTag("item", itemStack.serializeNBT());
            return compound;
        }

     

     

     

     

     

  5. 29 minutes ago, unassigned said:

    What? Why are you creating a file? Just create a new NBTTagCompound ( NBTTagCompound itemTag = new NBTTagCompound ), write the data to that tag, then add that tag to your TEs compound tag (in writeToNBT) (via NBTTagCompound#setTag ). Then access it when you go to read it via NBTagCompound#getTag and create a new ItemStack off this.

    I'm trying to use that method of doing it, but I'm getting two errors.

     

    Code:

    Spoiler
    
        @Override
        public void readFromNBT(NBTTagCompound compound)
        {
        	super.readFromNBT(compound);
            if (compound.hasKey("item"))
            {
                itemStack.deserializeNBT((NBTTagCompound) compound.getTag("item"));
            }
        }
    
        @Override
        public NBTTagCompound writeToNBT(NBTTagCompound compound)
        {
            super.writeToNBT(compound);
            compound.setTag("item", itemStack.serializeNBT());
            return compound;
        }

     

     

     

    First error, occurs upon placing block:

    Spoiler

    [19:03:26] [Server thread/FATAL] [minecraft/MinecraftServer]: Error executing task
    java.util.concurrent.ExecutionException: java.lang.NullPointerException
        at java.util.concurrent.FutureTask.report(Unknown Source) ~[?:1.8.0_192]
        at java.util.concurrent.FutureTask.get(Unknown Source) ~[?:1.8.0_192]
        at net.minecraft.util.Util.runTask(Util.java:54) [Util.class:?]
        at net.minecraft.server.MinecraftServer.updateTimeLightAndEntities(MinecraftServer.java:798) [MinecraftServer.class:?]
        at net.minecraft.server.MinecraftServer.tick(MinecraftServer.java:743) [MinecraftServer.class:?]
        at net.minecraft.server.integrated.IntegratedServer.tick(IntegratedServer.java:192) [IntegratedServer.class:?]
        at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:592) [MinecraftServer.class:?]
        at java.lang.Thread.run(Unknown Source) [?:1.8.0_192]
    Caused by: java.lang.NullPointerException
        at davidgingerich.davesmod.blocks.advancedblocks.datablock.DataTileEntity.writeToNBT(DataTileEntity.java:43) ~[DataTileEntity.class:?]
        at net.minecraftforge.common.util.BlockSnapshot.getTileNBT(BlockSnapshot.java:132) ~[BlockSnapshot.class:?]
        at net.minecraftforge.common.util.BlockSnapshot.<init>(BlockSnapshot.java:61) ~[BlockSnapshot.class:?]
        at net.minecraftforge.common.util.BlockSnapshot.<init>(BlockSnapshot.java:82) ~[BlockSnapshot.class:?]
        at net.minecraftforge.common.util.BlockSnapshot.getBlockSnapshot(BlockSnapshot.java:113) ~[BlockSnapshot.class:?]
        at net.minecraft.world.World.setBlockState(World.java:394) ~[World.class:?]
        at davidgingerich.davesmod.blocks.advancedblocks.datablock.DataBlock.onBlockPlacedBy(DataBlock.java:90) ~[DataBlock.class:?]
        at net.minecraft.item.ItemBlock.placeBlockAt(ItemBlock.java:205) ~[ItemBlock.class:?]
        at net.minecraft.item.ItemBlock.onItemUse(ItemBlock.java:57) ~[ItemBlock.class:?]
        at net.minecraftforge.common.ForgeHooks.onPlaceItemIntoWorld(ForgeHooks.java:884) ~[ForgeHooks.class:?]
        at net.minecraft.item.ItemStack.onItemUse(ItemStack.java:200) ~[ItemStack.class:?]
        at net.minecraft.server.management.PlayerInteractionManager.processRightClickBlock(PlayerInteractionManager.java:507) ~[PlayerInteractionManager.class:?]
        at net.minecraft.network.NetHandlerPlayServer.processTryUseItemOnBlock(NetHandlerPlayServer.java:769) ~[NetHandlerPlayServer.class:?]
        at net.minecraft.network.play.client.CPacketPlayerTryUseItemOnBlock.processPacket(CPacketPlayerTryUseItemOnBlock.java:68) ~[CPacketPlayerTryUseItemOnBlock.class:?]
        at net.minecraft.network.play.client.CPacketPlayerTryUseItemOnBlock.processPacket(CPacketPlayerTryUseItemOnBlock.java:13) ~[CPacketPlayerTryUseItemOnBlock.class:?]
        at net.minecraft.network.PacketThreadUtil$1.run(PacketThreadUtil.java:21) ~[PacketThreadUtil$1.class:?]
        at java.util.concurrent.Executors$RunnableAdapter.call(Unknown Source) ~[?:1.8.0_192]
        at java.util.concurrent.FutureTask.run(Unknown Source) ~[?:1.8.0_192]
        at net.minecraft.util.Util.runTask(Util.java:53) ~[Util.class:?]
        ... 5 more

     

    Second error, occurs upon trying to save game:

     

    Spoiler

    [19:03:27] [Server thread/ERROR] [FML]: A TileEntity type davidgingerich.davesmod.blocks.advancedblocks.datablock.DataTileEntity has throw an exception trying to write state. It will not persist. Report this to the mod author
    java.lang.NullPointerException: null
        at davidgingerich.davesmod.blocks.advancedblocks.datablock.DataTileEntity.writeToNBT(DataTileEntity.java:43) ~[DataTileEntity.class:?]
        at net.minecraft.world.chunk.storage.AnvilChunkLoader.writeChunkToNBT(AnvilChunkLoader.java:414) [AnvilChunkLoader.class:?]
        at net.minecraft.world.chunk.storage.AnvilChunkLoader.saveChunk(AnvilChunkLoader.java:185) [AnvilChunkLoader.class:?]
        at net.minecraft.world.gen.ChunkProviderServer.saveChunkData(ChunkProviderServer.java:214) [ChunkProviderServer.class:?]
        at net.minecraft.world.gen.ChunkProviderServer.saveChunks(ChunkProviderServer.java:242) [ChunkProviderServer.class:?]
        at net.minecraft.world.WorldServer.saveAllChunks(WorldServer.java:1061) [WorldServer.class:?]
        at net.minecraft.server.MinecraftServer.saveAllWorlds(MinecraftServer.java:468) [MinecraftServer.class:?]
        at net.minecraft.server.integrated.IntegratedServer.saveAllWorlds(IntegratedServer.java:274) [IntegratedServer.class:?]
        at net.minecraft.server.integrated.IntegratedServer.tick(IntegratedServer.java:177) [IntegratedServer.class:?]
        at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:592) [MinecraftServer.class:?]
        at java.lang.Thread.run(Unknown Source) [?:1.8.0_192]
     

     

     

     

    3
     

     

  6. 1 hour ago, diesieben07 said:

    A new instance.

    I told it to read from and write to a file called "test.bat", but for some reason, it's still not working or even creating the file.

     

    Spoiler
    
        @Override
        public void readFromNBT(NBTTagCompound compound)
        {
        	readStackFromFile("test.dat");
        }
    
        @Override
        public NBTTagCompound writeToNBT(NBTTagCompound compound)
        {
        	return writeStackToFile("test.dat");
        }
        
        public NBTTagCompound writeStackToFile(String fileName)
        {
            if (itemStack != null)
            {
                NBTTagCompound nbt = new NBTTagCompound();
                itemStack.writeToNBT(nbt);
                File file = new File(fileName);
                try
                {
                    file.createNewFile();
                    FileOutputStream fileoutputstream = new FileOutputStream(file);
                    CompressedStreamTools.writeCompressed(nbt, fileoutputstream);
                    fileoutputstream.close();
                }
                catch (Exception exception)
                {
                    exception.printStackTrace();
                }
                return nbt;
            }
            return null;
        }
            
        public void readStackFromFile(String file)
        {
        	FileInputStream fileinputstream = null;
        	NBTTagCompound nbt = null;
    		try
    		{
    			fileinputstream = new FileInputStream(file);
    		} catch (FileNotFoundException e)
    		{
    			e.printStackTrace();
    		}
    		try
    		{
    			nbt = CompressedStreamTools.readCompressed(fileinputstream);
    	    	itemStack = new ItemStack(nbt);
    		} catch (IOException e)
    		{
    			e.printStackTrace();
    		}
        }
    }

     

     

     

  7. 5 minutes ago, diesieben07 said:

    Like I said, store the stack in a sub-compound. I.e. create a new NBTTagCompound, write the ItemStack (and only the ItemStack) to it and then add it to "your own" compound.

    Pardon my bad understanding, are you saying that I should create a new instance of NBTTagCompound or a new type that derives from NBTTagCompound?

  8. 1 minute ago, diesieben07 said:

    Actually, I now know why.

    You need to follow this advice:

     

    The default NBT for tile entities contains a key "id", which conflicts with the ItemStack serialization.

    I'm checking it by right-clicking a block, and it swaps the item in the player's hand with the item in the DataTileEntity, which works fine until I reload, then whatever was in it is gone.

     

    So how can I get around the default setting?

  9. 4 minutes ago, diesieben07 said:

    Without seeing more of your code: no. We have zero context.

    Please clarify also what you mean by "not saving". How exactly did you come to this conclusion, which symptoms did you observe?

    I have a member variable of the type ItemStack in my DataTileEntity class, and I'd like it to still have a reference to whatever it had a reference to before I relogged. But it is null everytime I load up the world again.

     

    Spoiler
    
    import net.minecraft.init.Items;
    import net.minecraft.item.ItemStack;
    import net.minecraft.nbt.NBTTagCompound;
    import net.minecraft.tileentity.TileEntity;
    
    public class DataTileEntity extends TileEntity {
        
        ItemStack itemStack;
    
        public void setItemStackment(ItemStack itemStack)
        {
            this.itemStack = itemStack;
            markDirty();
        }
        
        public ItemStack getItemStackment() {
            return itemStack;
        }
    
        @Override
        public void readFromNBT(NBTTagCompound compound)
        {
            super.readFromNBT(compound);
            itemStack = new ItemStack(compound);
        }
    
        @Override
        public NBTTagCompound writeToNBT(NBTTagCompound compound)
        {
            super.writeToNBT(compound);
            return itemStack.writeToNBT(compound);
        }
    }

     

     

     

  10. Dangit, it's not saving the item. Is there anything that you can see that's clearly wrong with this code? I doubt I'm using the super right.

     

    Spoiler
    
        @Override
        public void readFromNBT(NBTTagCompound compound)
        {
            super.readFromNBT(compound);
            itemStack = new ItemStack(compound);
        }
    
        @Override
        public NBTTagCompound writeToNBT(NBTTagCompound compound)
        {
            super.writeToNBT(compound);
            return itemStack.writeToNBT(compound);
        }

     

     
     

     

  11. What should I replace "id" with? "Minecraft:DIAMOND"?

     

    Here's what I translated this into:

     

    Spoiler
    
        @Override
        public void readFromNBT(NBTTagCompound compound)
        {
            super.readFromNBT(compound);
            if(compound.hasKey("id"))
            {
            	itemStack = new ItemStack(compound); //itemStack is a member variable of this class.
            }
        }
    
        @Override
        public NBTTagCompound writeToNBT(NBTTagCompound compound)
        {
            super.writeToNBT(compound);
            return itemStack.writeToNBT(compound);
        }

     

     
     
     
     

     

  12. 8 minutes ago, unassigned said:
    
                    NBTTagCompound dataCompound = new NBTTagCompound();
                    ItemStack newStack = new ItemStack(Items.DIAMOND);
    
                    newStack.writeToNBT(dataCompound); //writes newStack data to dataCompound
    
                    if(dataCompound.hasKey("id")) { ItemStack fromCompoundStack = new ItemStack(dataCompound); } //if the dataCompound has a ItemStack data, make a new stack from that data.

     

     

  13. So the code below will save an integer to wherever (I just know that it's important to save it or things will get screwed up), but how do I save something such as an ItemStack to in a similar manner? Please tell me that I'm not going to have to break it down into simple data types to save it...

     

    Spoiler
    
        @Override
        public NBTTagCompound writeToNBT(NBTTagCompound compound)
        {
            super.writeToNBT(compound);
            compound.setInteger("int", int);
            return compound;
        }

     

     
     

     

  14. 6 hours ago, desht said:

    Don't do that, please. You're registering your TE with a plain string and not even prefixing it with your mod ID.  That method is even deprecated in recent Forge builds.  Correct way is:

    
    GameRegistry.registerTileEntity(YourTileEntity.class, new ResourceLocation("your_mod_id", "your_tile_entity_name));

     

    You'll know pretty quickly if you registered it when you attempt to place any blocks of that tile entity. If you can place them, your TE is registered :)  However, if the registerTileEntity() call didn't throw an exception or log a warning in your log file, it should be safe to assume it succeeded.

    I disabled the line of code that I had in Main, and nothing happened. Then I realized that I had put code in CommonProxy to register it, and apparently didn't need anything in Main. So I commented out the code in CommonProxy to see what would happen. I was able to place the block and interact with it and everything, and I saw no indication in-game that something was wrong, but errors were repeatedly logged in the console complaining about missing mapping or something.

  15. 5 hours ago, diesieben07 said:

    Show more of your code.

     

    You can do the following to post code (ordered from best to "worst"):

    1. Create a Git repository of your code.
    2. Use Github Gists.
    3. Use pastebin.com or similar.
    4. Use the Code-Button on the forum editor (opening and closing angle bracket icon).
        @Override
        public boolean onBlockActivated(World world, BlockPos pos, IBlockState state, EntityPlayer player, EnumHand hand,
                    EnumFacing side, float hitX, float hitY, float hitZ) {
            if (!world.isRemote) {
                if (side == state.getValue(FACING)) {
                    //world.spawnEntity(new EntityItem(world, pos.getX(), pos.getY(), pos.getZ(), new ItemStack(Items.DIAMOND)));
                                                                                           
        		    EntityZombie mobEntity = new EntityZombie(world);
        		    mobEntity.setPosition(pos.getX(), pos.getZ(), pos.getZ());
        		    world.spawnEntity(mobEntity);
                }
            }
            return true;
        }

     

  16. So I've got some simple code that should spawn in a zombie in the onBlockActivated method of my block, but it doesn't seem to be doing anything, even though I could spawn in item entities just fine.

     

                    EntityZombie mobEntity = new EntityZombie(world);
                    mobEntity.setPosition(pos.getX(), pos.getZ(), pos.getZ());
                    world.spawnEntity(mobEntity);

     

    Also, if someone could tell me how to properly post code, that would be great.

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.