Welcome, Guest. Please login or register

Author Topic: Helping out with Forge PRs  (Read 2497 times)

0 Members and 1 Guest are viewing this topic.

Offline mezz

  • Global Moderator
  • Tree Puncher
  • *****
  • Posts: 3
  • Karma: +1/-0
  • Thank You
  •   - Given: 0
  •   - Receive: 1
    • View Profile
Helping out with Forge PRs
« on: November 25, 2016, 10:50:05 pm »
Hi, I'm mezz.

I'm the author of JEI, and I have maintained Forestry the last couple years.

I have also made several contributions to Forge using Pull Requests including:
...and a bunch of other stuff.


I will be helping to clean up and streamline Forge Pull Requests.

The primary goal is to get more PRs up to standard and keep them from sitting for a long time in a bad state with no response or update. I'll be working with other modders to review them in a more comprehensive way, and then pass them to Lex for final review.

That means that PR issues will have to get through me first. That doesn't mean it has to be a more difficult process though. In working towards the primary goal, I want to help everyone write effective PRs that are likely to be accepted.

Below is an explanation of what it takes to write a good Forge Pull Request.


What is a Pull Request (PR) to Forge?

Mods are built on top of Forge, but there are some things that Forge doesn't support, and that limits what mods can do. 
When modders run into something like that, they can make a change to Forge to support it, and submit that change as a Pull Request on Github.

However to make a good Forge Pull Request, you have to understand a bit about what the Forge project is, its goals, and its limitations.

What Exactly is Forge?

At a high level, Forge is a mod compatibility layer on top of Minecraft.   
Early mods edited Minecraft's code directly (like coremods do now), but ran into conflicts with each other when they edited the same things. They also ran into issues when one mod changed behavior in ways that the other mods could not anticipate (like coremods do now), causing mysterious issues and lots of headaches. 

By using something like Forge, mods can centralize common changes and avoid conflicts. 
Forge also includes supporting structures for common mod features like Capabilities, Registries, Fluid handling, the Ore Dictionary, and others that allow mods to work together better.

When writing a good Forge Pull Request, you also have to know what Forge is at a lower level.   
There are two main types of code in Forge: Minecraft patches, and Forge code.

Patches

Patches are applied as direct changes to Minecraft's source code, and aim to be as minimal as possible. 
Every time Minecraft code changes, all the Forge patches need to be looked over carefully and applied correctly to the new code. 
This means that large patches that change lots of things are difficult to maintain, so Forge aims to avoid those and keep patches as small as possible. 
In addition to making sure the code makes sense, reviews for patches will focus on minimizing the size.

There are many strategies to make small patches, and reviews will often point out better methods to do things. 
Forge patches often insert a single line that fires an event or a code hook, which affects the code after it if the event meets some condition. 
This allows most of the code to exist outside of the patch, which keeps the patch small and simple.

For more detailed information about creating patches, see the wiki.

Forge Code

Aside from the patches, Forge code is just normal java code. It can be event code, compatibility features, or anything else that's not directly editing Minecraft code.
When Minecraft updates, Forge code has to update just like everything else. However, it's much easier because it is not directly entangled in the Minecraft code.

Because this code stands on its own, there is no size restriction like there is with the patches.

In addition to making sure the code makes sense, reviews for this code will focus on making the code clean, with proper formatting and java documentation.

Explain Yourself

All Pull Requests need to answer the question: why is this necessary? 
Any code added to Forge needs to be maintained, and more code means more potential for bugs, so solid justification is needed for adding code.

A common Pull Request issue is offering no explanation, or giving cryptic examples for how the Pull Request might theoretically be used.
This only delays the Pull Request process. 
A clear explanation for the general case is good, but also give a concrete example of how your mod needs this Pull Request.

Sometimes there is better way to do what you wanted, or a way to do it without a Pull Request at all. Code changes can not be accepted until those possibilities have been completely ruled out.

Show that it Works

The code you submit to Forge should work perfectly, and it's up to you to convince the reviewers that it does. 

One of the best ways to do that is to add an example mod or junit test to Forge that makes use of your new code and shows it working. 

To set up and run a Forge Environment with the example mods, see cpw's video tutorial.

Breaking Changes in Forge

Forge can't make changes that break the mods that depend on it. 
This means that Pull Requests have to ensure that they do not break binary compatibility with previous Forge versions. 
A change that breaks binary compatibility is called a Breaking Change.

There are some exceptions to this, Forge accepts Breaking Changes at the beginning of new Minecraft versions, where Minecraft itself already causes Breaking Changes for modders. 
Sometimes an emergency breaking change is required outside of that time window, but it is rare and can cause dependency headaches for everyone in the modded Minecraft community.

Outside of those exceptional times Pull Requests with breaking changes are not accepted, they must be adapted to support the old behavior or wait for the next Minecraft version.

Be Patient, Civil, and Empathetic

When submitting Pull Requests you will often have to survive code review and make several changes before it is the best Pull Request possible. 
Keep in mind that code review is not judgement against you. Bugs in your code are not personal. Nobody is perfect, and that's why we're working together.

Negativity will not help, threatening to give up on your Pull Request and write a coremod instead will just make people upset and make the modded ecosystem worse. 
It's important that while working together you assume the best intentions of the people who are reviewing your Pull Request and not take things personally. 

Review

If you do your best to understand the slow and perfectionistic nature of the Pull Request process, we will do our best to understand your point of view as well.

After your Pull Request has been reviewed and cleaned up to the best of everyone's ability, it will be marked for a final review by Lex, who has the final say on what is included in the project or not.

Thanks for contributing, and I'll see you in code review!
« Last Edit: November 25, 2016, 11:10:39 pm by mezz »

Offline LexManos

  • Forge Code God
  • Reality Controller
  • *****
  • Posts: 7,287
  • Karma: +1,500/-287
  • Thank You
  •   - Given: 1
  •   - Receive: 924

  • "I am new!"

    • View Profile
Re: Helping out with Forge PRs
« Reply #1 on: November 25, 2016, 11:16:50 pm »
Everyone welcome a new Forge team member. He is in charge of all Pull Requests and Issues on the Forge GitHub now.
Him and I will be talking through everything that is needed to be done in a PR.
I will no longer be processing things until he tags me in them.
So if you have concerns about your PR speak to him.
This is an attempt to make the process a smoother and "friendlier" process. Lets see how it goes!

So ya, say hello!
If you don't know how to run a java file you're a moron and should watch this: http://www.youtube.com/watch?v=j6uMF-PjGT4
Patreon: http://www.patreon.com/lexmanos (Because, people asked 0.o)
Paypal: LexManos@gmail.com (Again added on request)

 

Sitemap 1 2 3 4 5 6 7 8 9 10 
Close
Please register or Login to join in on the community!