Jump to content

[1.7.10] NBTTag data resets on rejoining world


Elrol_Arrowsend

Recommended Posts

the way that my code works:

shift + right click on the blocks will open a gui where you can name the block (floor)

right click on the block will show the teleport gui which shows each valid teleport destination as floor 1, floor 2, etc unless the floor is named, ie floor 1, floor 2,  roof

clicking on the button for the different floors will teleport the player to that location.

all of this works the only problem is once i leave the world and rejoin the world the floors are no longer named properly. here are the majority of the code involved:

 

TileEntityElevator:

 

package elrol.guiElevator.main;

import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.tileentity.TileEntity;

public class TileEntityElevator extends TileEntity {
public NBTTagCompound tag = new NBTTagCompound();

public TileEntityElevator(){
}

@Override
public void readFromNBT(NBTTagCompound tag){
	//this.name = tag.getString("name");
	//this.isNamed = tag.getBoolean("named");
	this.tag.setString("name",tag.getString("name"));
	this.tag.setBoolean("named",tag.getBoolean("named"));
	super.readFromNBT(tag);	
}

@Override
public void writeToNBT(NBTTagCompound tag){
	if(tag.getString("name") == ""){
		tag.setBoolean("named", false);	
	}else{
		//System.out.println(name + ", " + isNamed);
		tag.setString("name",this.tag.getString("name"));
		tag.setBoolean("named", true);

	}


	super.writeToNBT(tag);
}

public NBTTagCompound getNBTTag(){
	return this.tag;
}

public String getName(){
	return this.tag.getString("name");
}

public void setName(String name){
	this.tag.setString("name", name);
}

public boolean isNamed(){
	if(this.tag.getString("name") != null){
		return true;
	}else{
	return false;
	}
}
}

 

 

FloorSelectGUI

 

package elrol.guiElevator.main;

import java.awt.List;

import net.minecraft.client.gui.GuiButton;
import net.minecraft.client.gui.GuiScreen;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.init.Blocks;
import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.util.ResourceLocation;
import net.minecraft.world.World;

import org.lwjgl.input.Keyboard;
import org.lwjgl.opengl.GL11;

public class FloorSelectGUI extends GuiScreen{

public static ResourceLocation gui = new ResourceLocation(ModInfo.MODID, "textures/gui/floor_select.png");
public static int guiWidth = 248;
public static int guiHeight = 166;

GuiButton floorButton;

public EntityPlayer player;

public int X;
public int Y;
public int Z;

public World world;

public FloorSelectGUI (World world, int x, int y, int z, EntityPlayer player){
	this.X = x;
	this.Y = y;
	this.Z = z;

	this.player = player;
	this.world = world;
}

@Override
public void drawScreen(int x, int y,float tick){
	int guiX = (width-guiWidth)/2;
	int guiY = (height-guiHeight)/2;

	GL11.glColor4f(1, 1, 1, 1);
	mc.renderEngine.bindTexture(gui);
	drawTexturedModalRect(guiX, guiY, 0, 0, guiWidth, guiHeight);

	drawStrings(guiX, guiY);

	super.drawScreen(x, y, tick);

}

public void initGui(){
	int guiX = (width-guiWidth)/2;
	int guiY = (height-guiHeight)/2;
	int floor = 0;
	int col = 0;
	buttonList.clear();

	for(int blockY = 0; blockY < 256; blockY++){
		if(world.getBlock(X, blockY, Z) == ElevatorMain.elevator){
			if(isFloorValid(world, X, blockY, Z, world.getBlockMetadata(X, blockY,Z))){
				if(floor < 24){
					if(((TileEntityElevator)world.getTileEntity(X, blockY, Z)).isNamed()){
						System.out.println("Floor is Named:" + ((TileEntityElevator)world.getTileEntity(X, blockY, Z)).getName() + " at: " + X + ", " + blockY + ", " + Z);
						buttonList.add(floorButton = new GuiButton(blockY, guiX + 9 + (83*col) , guiY + 20 + (16 * floor)-(16 * (8 * col)), 64, 16, ((TileEntityElevator)world.getTileEntity(X, blockY, Z)).getName()));
					}else{
						buttonList.add(floorButton = new GuiButton(blockY, guiX + 9 + (83*col) , guiY + 20 + (16 * floor)-(16 * (8 * col)), 64, 16, "Floor " + (floor+1)));	
					}						
					floor++;
					if(floor > 7 && floor < 16){
						col = 1;
					}
					if(floor > 15){
						col = 2;
					}
					//System.out.println("elevator found at Y:" + blockY + "(" + floor + "[" + ((TileEntityElevator)world.getTileEntity(X, blockY, Z)).name +"]" +")");	
				}
			}
		}
	}

	super.initGui();
}

public void drawStrings(int guiX, int guiY){
	fontRendererObj.drawString("Select a floor", guiX+8,guiY+8, 0x000000);

}

protected void actionPerformed(GuiButton button){
	if(button.id > 0 && button.id < 256){
		System.out.println(button.id);
		switch(world.getBlockMetadata(X, button.id, Z)){
		case 0: player.setPositionAndUpdate((double)X + 0.5D, (double)button.id - 2D, (double)Z + 0.5D);
			break;
		case 1: player.setPositionAndUpdate((double)X + 0.5D, (double)button.id + 1D, (double)Z + 0.5D);
			break;
		case 2: player.setPositionAndUpdate((double)X + 0.5D, (double)button.id-1, (double)Z - 0.5D);
			break;
		case 3: player.setPositionAndUpdate((double)X + 0.5D, (double)button.id-1, (double)Z + 1.5D);
			break;
		case 4: player.setPositionAndUpdate((double)X - 0.5D, (double)button.id-1, (double)Z + 0.5D);
			break;
		case 5: player.setPositionAndUpdate((double)X + 1.5D, (double)button.id-1, (double)Z + 0.5D);
			break;
		default: System.out.println("ERROR WITH METADATA :" + world.getBlockMetadata(X, button.id, Y));
		}
	mc.displayGuiScreen(null);
	}
}

protected void keyTyped(char c, int key){
	switch(key){
	case Keyboard.KEY_E:
		mc.displayGuiScreen(null);

	case Keyboard.KEY_ESCAPE:
		mc.displayGuiScreen(null);
	}
}

public boolean isFloorValid(World world, int x, int y, int z, int meta){
	System.out.println(x + ", " + y + ", " + z + ", " + world.getBlockMetadata(x,y,z));
	if(world.getBlockPowerInput(x, y, z) == 0){
		switch(world.getBlockMetadata(x,y,z)){
		case 0:
			if(world.getBlock(x, y-1, z).getCollisionBoundingBoxFromPool(world, x, y, z) == null && world.getBlock(x, y-2, z).getCollisionBoundingBoxFromPool(world, x, y, z) == null ){
				System.out.println("has space");
				return true;
			}else{
				System.out.println(world.getBlock(x, y-1, z).getUnlocalizedName() + ", " + world.getBlock(x, y-2, z).getUnlocalizedName());
				return false;}
		case 1:
			if(world.getBlock(x, y+1, z).getCollisionBoundingBoxFromPool(world, x, y, z) == null  && world.getBlock(x, y+2, z).getCollisionBoundingBoxFromPool(world, x, y, z) == null ){
				System.out.println("has space");
				return true;
			}else{
				System.out.println(world.getBlock(x, y+1, z).getUnlocalizedName() + ", " + world.getBlock(x, y+2, z).getUnlocalizedName());
				return false;}
		case 2:
			if(world.getBlock(x, y, z-1).getCollisionBoundingBoxFromPool(world, x, y, z) == null  && world.getBlock(x, y-1, z-1).getCollisionBoundingBoxFromPool(world, x, y, z) == null ){
				System.out.println("has space");
				return true;
			}else{
				System.out.println(world.getBlock(x, y, z-1).getUnlocalizedName() + ", " + world.getBlock(x, y-1, z-1).getUnlocalizedName());
				return false;}
		case 3:
			if(world.getBlock(x, y, z+1).getCollisionBoundingBoxFromPool(world, x, y, z) == null  && world.getBlock(x, y-1, z+1).getCollisionBoundingBoxFromPool(world, x, y, z) == null ){
				System.out.println("has space");
				return true;
			}else{System.out.println(world.getBlock(x, y, z+1).getUnlocalizedName() + ", " + world.getBlock(x, y-1, z+1).getUnlocalizedName());
			return false;}
		case 4:
			if(world.getBlock(x-1, y, z).getCollisionBoundingBoxFromPool(world, x, y, z) == null  && world.getBlock(x-1, y-1, z).getCollisionBoundingBoxFromPool(world, x, y, z) == null ){
				System.out.println("has space");
				return true;
			}else{System.out.println(world.getBlock(x-1, y, z).getUnlocalizedName() + ", " + world.getBlock(x-1, y-1, z).getUnlocalizedName());
			return false;}
		case 5:
			if(world.getBlock(x+1, y, z).getCollisionBoundingBoxFromPool(world, x, y, z) == null  && world.getBlock(x+1, y-1, z).getCollisionBoundingBoxFromPool(world, x, y, z) == null ){
				System.out.println("has space");
				return true;
			}else{System.out.println(world.getBlock(x+1, y, z).getUnlocalizedName() + ", " + world.getBlock(x+1, y-1, z).getUnlocalizedName());
			return false;}
		default: 
			System.out.println("ERROR: METADATA > 5");
			return false;
		}
	}else{
		return false;
	}


}
}

 

 

Elevator:

 

package elrol.guiElevator.main;

import net.minecraft.block.BlockContainer;
import net.minecraft.block.material.Material;
import net.minecraft.client.Minecraft;
import net.minecraft.client.renderer.texture.IIconRegister;
import net.minecraft.creativetab.CreativeTabs;
import net.minecraft.entity.EntityLivingBase;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.item.ItemStack;
import net.minecraft.tileentity.TileEntity;
import net.minecraft.util.IIcon;
import net.minecraft.util.MovingObjectPosition;
import net.minecraft.util.Vec3;
import net.minecraft.world.World;

public class Elevator extends BlockContainer{


public IIcon side;
protected IIcon field_150164_N;
    
public Elevator(String name, CreativeTabs tab, float hardness, float resistance, SoundType stepSound) {
	super(Material.iron);
	this.setBlockName(name);
	this.setHardness(hardness);
	this.setResistance(resistance);
	this.setBlockTextureName(ModInfo.MODID + ":" + name);
	this.setCreativeTab(tab);
	this.setStepSound(stepSound);

}

public boolean onBlockActivated(World world, int x, int y, int z, EntityPlayer player, int par1, float par2, float par3, float par4)
    {
	if(!world.isRemote){
		if(player.isSneaking()){
			Minecraft.getMinecraft().displayGuiScreen(new ElevatorNamingGUI(world, x, y, z, player));
			return false;
		}else{
			Minecraft.getMinecraft().displayGuiScreen(new FloorSelectGUI(world, x, y, z, player));
			return true;
		}

		//if(player.isSneaking()){
		//}else{Minecraft.getMinecraft().displayGuiScreen(new FloorSelectGUI(world, x, y, z, player));}
	}
	else{
		return false;	
	}
    }

@Override
public TileEntity createNewTileEntity(World p_149915_1_, int p_149915_2_) {
	try{
		return new TileEntityElevator();	
	}catch (Exception var3){
		throw new RuntimeException(var3);
	}

}

public boolean hasTileEntity(int meta){
	return true;
}

public void registerBlockIcons(IIconRegister icon){
	this.blockIcon = icon.registerIcon(this.textureName);
	this.side = icon.registerIcon(this.textureName + "_face");
}

public IIcon getIcon(int side, int meta){
	if(side == meta){
		return this.side;
	}else{
		return this.blockIcon;
	}
}

public int onBlockPlaced(World world, int x, int y, int z, int side, float hitX, float hitY, float hitZ, int meta)
    {
	world.setBlockMetadataWithNotify(x, y, z, side, 2);
	return side;
    }
}

 

 

FloorNameingGUI

 

package elrol.guiElevator.main;

import net.minecraft.client.gui.GuiButton;
import net.minecraft.client.gui.GuiScreen;
import net.minecraft.client.gui.GuiTextField;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.util.ResourceLocation;
import net.minecraft.world.World;

import org.lwjgl.input.Keyboard;
import org.lwjgl.opengl.GL11;

public class ElevatorNamingGUI extends GuiScreen{
public static ResourceLocation gui = new ResourceLocation(ModInfo.MODID, "textures/gui/floor_name.png");
public static int guiWidth = 248;
public static int guiHeight = 166;

GuiTextField nameInput;

GuiButton okButton;
GuiButton cancelButton;

public EntityPlayer player;

public int X;
public int Y;
public int Z;

public World world;

public ElevatorNamingGUI (World world, int x, int y, int z, EntityPlayer player){
	this.X = x;
	this.Y = y;
	this.Z = z;

	this.player = player;
	this.world = world;
}

@Override
public void drawScreen(int x, int y,float tick){
	int guiX = (width-guiWidth)/2;
	int guiY = (height-guiHeight)/2;

	GL11.glColor4f(1, 1, 1, 1);
	mc.renderEngine.bindTexture(gui);
	drawTexturedModalRect(guiX, guiY, 0, 0, guiWidth, guiHeight);
	this.nameInput.drawTextBox();
	drawButtons();
	drawStrings(guiX, guiY);

	super.drawScreen(x, y, tick);

}

public void initGui(){
	int guiX = (width-guiWidth)/2;
	int guiY = (height-guiHeight)/2;

	buttonList.clear();
	this.nameInput = new GuiTextField(this.fontRendererObj, guiX+74, guiY+32, 100, 20);
        nameInput.setMaxStringLength(32);
	this.nameInput.setFocused(true);
	if(((TileEntityElevator)world.getTileEntity(X, Y, Z)).isNamed()){
		this.nameInput.setText(((TileEntityElevator)world.getTileEntity(X, Y, Z)).getName());
		System.out.println(((TileEntityElevator)world.getTileEntity(X, Y, Z)).getName());
	}else{
		this.nameInput.setText("");
	}
        
        buttonList.add(okButton = new GuiButton(Y, guiX+79, guiY+64, 40, 20, "Rename"));
        buttonList.add(cancelButton = new GuiButton(1, guiX+129, guiY+64, 40, 20, "Cancel"));
	super.initGui();
}

public void drawButtons(){

}

public void drawStrings(int guiX, int guiY){
	fontRendererObj.drawString("Name the floor", guiX+8,guiY+8, 0x000000);
}

protected void actionPerformed(GuiButton button){

	if(button.id == Y){
		NBTTagCompound tag = new NBTTagCompound();
		tag.setString("name", this.nameInput.getText().trim());
		tag.setBoolean("named", true);
		System.out.println(Y);
		((TileEntityElevator)world.getTileEntity(X, button.id, Z)).readFromNBT(tag);
		mc.displayGuiScreen(null);
		return ;
	}else{
		mc.displayGuiScreen(null);	
	}
}

protected void keyTyped(char c, int key){
	this.nameInput.textboxKeyTyped(c, key);
        
	if(!this.nameInput.isFocused()){
		switch(key){
		case Keyboard.KEY_E:
			mc.displayGuiScreen(null);

		case Keyboard.KEY_ESCAPE:
			mc.displayGuiScreen(null);
		}
	}

}

public void updateScreen()
    {
        super.updateScreen();
        this.nameInput.updateCursorCounter();
    }

protected void mouseClicked(int x, int y, int btn) {
        super.mouseClicked(x, y, btn);
        this.nameInput.mouseClicked(x, y, btn);
    }
}

 

Link to comment
Share on other sites

Guis are client side. If you want this info present on the server, you need packets

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

@gummy

You totally missed the point :D

 

IGuiHandler is nothing more than super-simple call-do system. It handles only opening of gui, nothing more.

 

Every mod can have one IGuiHandler implementation. Whenever you call "player.openGui" you will be passing Mod's instance.

If called on client - your client will open GUI.

If called on server - the server will attempt to open container and if succesful - it will send packet to client that will call opening Gui for given container.

Packet that opens gui on client can have 3 integers shipped within. They are called x/y/z but can ship any kind of data. That's it.

 

If you need ANY kind of synchronization you will (almost) always write custom packets. End of story.

 

Only built-in systems (not counting internals like ItemStacks which are always synced) are placed in:

Entity:

IEntityAdditionalSpawnData // Allows sending additional data when client starts seeing entity (becomes visible).

DataWatcher // well... don't. And if you must - only for your shit.

 

TileEntity:

getDescriptionPacket() + onDataPacket(...) // Server writes shit, client reads shit. Sent only when TE is being loaded by client (becomes visible).

 

Container:

ICrafting#sendProgressBarUpdate(...) // send shit with integer ID and integer data.

ICrafting can be obtained like this (from Container): ICrafting iCrafting = (ICrafting) this.crafters.get(index); // and yeah, you can for-interate crafters.

updateProgressBar(...) // Receiver (client) for some integer data with given integer ID.

There is also:

detectAndSendChanges();

Which can be overriden and filled with your call-to-send stuff. One plus is that is will be called by vanilla whenever someone opens container and that means anything you put there will be called on opening (thus: auto-sync).

 

TileEntity + Container:

You can combine methods from Container to send data from TileEntity. Hell, there is even a "nice" abstraction layer on TileEntity:

getField(...) // by some ID

setFiled(...) // By some ID, set to some integer.

Which can be used with methods from TileEntity to send simple integer data between TileEntity and container.

 

There are few more things, but not worth mentioning. Any inventory or slots / guis sync must be made by modder.

 

Disclaimer: I am remembering systems/code from very old parts of my mod (months), so might messed up something with Container stuff.

1.7.10 is no longer supported by forge, you are on your own.

Link to comment
Share on other sites

Each time something changes in a GUI you need to send it to the server like others have stated. You also should have the server update the client in the detectAndSendChanges() bit of the container.

 

Below is code for sending a String as a Packet with 1.0.7.10 taken from my mod (As a result it will need modification) as an Example.

 

MCIBasicPacket.java

 

package stucuk.mcicraft.core.util;

 

import stucuk.mcicraft.core.MCICraft;

import cpw.mods.fml.client.FMLClientHandler;

import cpw.mods.fml.common.network.simpleimpl.IMessage;

import cpw.mods.fml.common.network.simpleimpl.MessageContext;

import cpw.mods.fml.relauncher.Side;

import cpw.mods.fml.relauncher.SideOnly;

import io.netty.buffer.ByteBuf;

import net.minecraft.entity.player.EntityPlayer;

import net.minecraft.entity.player.EntityPlayerMP;

 

public class MCIBasicPacket implements IMessage {

 

public void handlePacket(EntityPlayer player, Side side)

{

//

}

 

@Override

public void fromBytes(ByteBuf buffer) {

//

}

 

@Override

public void toBytes(ByteBuf buffer) {

//

}

 

@SideOnly(Side.CLIENT)

public void hpc(MessageContext ctx)

{

handlePacket(FMLClientHandler.instance().getClient().thePlayer,ctx.side);

}

 

public void onMessage(MessageContext ctx) {

 

    switch (ctx.side)

    {

        case CLIENT:

        hpc(ctx);

        break;

 

        case SERVER:

        handlePacket(ctx.getServerHandler().playerEntity,ctx.side);

        break;

 

        default:

    }

}

   

    public static void sendToServer(IMessage packet)

    {

    MCICraft.mcipacketsystem.instance().sendToServer(packet);

    }

   

    public static void sendToPlayer(IMessage packet, EntityPlayerMP player)

    {

    MCICraft.mcipacketsystem.instance().sendTo(packet, player);

    }

}

 

 

 

PacketMCI_String.java

 

package stucuk.mcicraft.core.packets;

 

import io.netty.buffer.ByteBuf;

import net.minecraft.block.Block;

import net.minecraft.entity.player.EntityPlayer;

import stucuk.mcicraft.core.MCICraft;

import stucuk.mcicraft.core.interfaces.IMCIPacketHandler_String;

import stucuk.mcicraft.core.util.MCIBasicPacket;

import cpw.mods.fml.common.network.ByteBufUtils;

import cpw.mods.fml.common.network.simpleimpl.IMessage;

import cpw.mods.fml.common.network.simpleimpl.IMessageHandler;

import cpw.mods.fml.common.network.simpleimpl.MessageContext;

import cpw.mods.fml.relauncher.Side;

 

public class PacketMCI_String extends MCIBasicPacket implements IMessage, IMessageHandler<PacketMCI_String, IMessage> {

    private int x,y,z;

private String value;

private byte extra;

 

public PacketMCI_String(){

 

}

 

    public PacketMCI_String(int x, int y, int z, String value, byte extra){

this.x      = x;

this.y      = y;

this.z      = z;

this.value  = value;

this.extra  = extra;

}

   

@Override

public void toBytes(ByteBuf buffer) {

buffer.writeInt(x);

buffer.writeInt(y);

buffer.writeInt(z);

ByteBufUtils.writeUTF8String(buffer, value);

buffer.writeByte(extra);

}

@Override

public void fromBytes(ByteBuf buffer) {

x    = buffer.readInt();

y    = buffer.readInt();

z    = buffer.readInt();

value = ByteBufUtils.readUTF8String(buffer);

extra = buffer.readByte();

}

 

@Override

public void handlePacket(EntityPlayer player, Side side)

{

Block block = MCICraft.getBlock(player.worldObj,x,y,z);

       

        if (block != null && block instanceof IMCIPacketHandler_String)

        ((IMCIPacketHandler_String)block).HandlePacket(player,x,y,z,value,extra);

}

 

public static void send(int x, int y, int z, String value, byte extra)

{

sendToServer(new PacketMCI_String(x,y,z,value,extra));

}

 

@Override

public IMessage onMessage(PacketMCI_String message, MessageContext ctx) {

message.onMessage(ctx);

 

return null;

}

 

}

 

 

 

MCIPacketSystem.java

 

package stucuk.mcicraft.core.util;

 

import cpw.mods.fml.common.network.NetworkRegistry;

import cpw.mods.fml.common.network.simpleimpl.IMessage;

import cpw.mods.fml.common.network.simpleimpl.IMessageHandler;

import cpw.mods.fml.common.network.simpleimpl.SimpleNetworkWrapper;

import cpw.mods.fml.relauncher.Side;

 

public class MCIPacketSystem {

private int count = 0;

private SimpleNetworkWrapper INSTANCE;

 

public MCIPacketSystem(String name)

{

INSTANCE = NetworkRegistry.INSTANCE.newSimpleChannel(name);

}

 

public <REQ extends IMessage, REPLY extends IMessage> void registerPacket(Class<? extends IMessageHandler<REQ, REPLY>> messageHandler, Class<REQ> requestMessageType, Side side)

{

INSTANCE.registerMessage(messageHandler, requestMessageType, count, side);

count++;

}

 

public SimpleNetworkWrapper instance()

{

return INSTANCE;

}

 

public void inc()

{

count++;

}

}

 

 

 

In the mods class:

public static final MCIPacketSystem mcipacketsystem = new MCIPacketSystem("yourmodname");

 

In PreInit of the mod:

mcipacketsystem.registerPacket(PacketMCI_String.class, PacketMCI_String.class, Side.SERVER);

 

The Side.SERVER is the destination.

 

In your GUI for your block you would use the following when the string changed:

PacketMCI_String.send(xCoord,yCoord,zCoord,"The Text",(byte)0)

 

The handlePacket section of the PacketMCI_String would need to be modified to set the string on the block.

Link to comment
Share on other sites

Never used it but as name suggests its "Inter Mod Communication Packet Handler" which can be used to make 2 or more mods to establish "weak" kind of communication without having to develop with their dev-releases (not obfuscated jars or sources) and/or java reflection.

 

This basically allows one mod to send data to other mod via "local packet". Obviously - this has to be implemented by mod and handled somehow.

 

From what I remember it allows you to send ItemStack (which can contain any data in its NBT) or maybe a String (i don't remember really). But basically that's the idea of this thing. Do note that it has nothing to do with networking.

 

EDIT As I got confused:

Well, as said "I never used it". OP asked what it is and I simply assumed that it's a Forge class, because of my knowledge of existance of InterModComms I assumed that that's this class :P

So basically I described something else above. :D

1.7.10 is no longer supported by forge, you are on your own.

Link to comment
Share on other sites

@Ernio: IMClPacketHandler_String is just an interface. It has nothing to do with mod communication. I = Interface. MCI = shorthand for my mod (MCI Craft) and "PacketHandler" is because its for a block handling the packet data that has just been received.

 

What is the IMClPacketHandler. Its the only bit im missing

 

Its an interface. Its just a helper that allows you to treat a class as if it was just that interface. If a class implements the interface then it has to have all the members of that interface. It basically allows you to easily use generic code for multiple classes without them having to inherit from a specific class. It also allows you to check if a class has a specific interface (You can make dummy interfaces that have no members) so that you can treat it differently.

 

The following is an example of using an interface. You add them after the word "implements":

public class BlockSound extends BlockContainer implements IMCIPacketHandler_String, IMCIPacketHandler_XYZ, IMCIPacketHandler_Float, INoMCILocation {

 

IMCIPacketHandler_String.java

 

package stucuk.mcicraft.core.interfaces;

 

import net.minecraft.entity.player.EntityPlayer;

 

public interface IMCIPacketHandler_String {

public void HandlePacket(EntityPlayer player, int x, int y, int z, String value, byte extra);

}

 

 

You could however change the handlePacket to be hardcoded and just update your block/tile directly (Though a generic solution is more future proof)

 

And then how would i get that string to set the name in the gui

 

There is two ways to do it. You can either use getDescriptionPacket() and onDataPacket() on the TileEntity (Which then sends clients data when they are in range or if you have called markDirty() which sends it again if the client already has received data from the server for that tile already) or you can send the data via individual packets (using detectAndSendChanges in your gui's container class). The advantage to the first method is that its simple, its basically just sending a NBT to the client from the server. The advantage of individual packets is that you can send the GUI a smaller amount of information and only when your in the GUI.

 

For your needs the first method is likely the best as your data won't be constantly being updated (Like if you had energy levels which you wanted on the GUI which could fluctuate oftern). You would need to check in your GUI if the blocks TileEntity had a different name to what it was before so that the GUI could be updated with the current name.

 

So you just need to add the following to your TileEntity to make it send data to the client. You need to make sure your string is being saved/loaded in the writeToNBT and readFromNBT.

 

	@Override
public Packet getDescriptionPacket()
{
    NBTTagCompound tagCompound = new NBTTagCompound();
    writeToNBT(tagCompound);
    return new S35PacketUpdateTileEntity(xCoord, yCoord, zCoord, 0, tagCompound);
}

@Override
public void onDataPacket(NetworkManager networkManager, S35PacketUpdateTileEntity packet) 
{		
    readFromNBT(packet.func_148857_g());	    
}

 

When the string is updated on the server(When you receive a packet from a client), you need to use markDirty() so that it then updates all clients near the tileentity.

 

Example code for handing the packet on a block that implements IMCIPacketHandler_String:

	@Override
public void HandlePacket(EntityPlayer player, int x, int y, int z, String value, byte extra)
{
	TileEntity te = player.worldObj.getTileEntity(x,y,z);

	if (te == null || !(te instanceof TileSound))
		return;

	((TileSound)te).name = value;
	((TileSound)te).markDirty();
}

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • They were already updated, and just to double check I even did a cleanup and fresh update from that same page. I'm quite sure drivers are not the problem here. 
    • i tried downloading the drivers but it says no AMD graphics hardware has been detected    
    • Update your AMD/ATI drivers - get the drivers from their website - do not update via system  
    • As the title says i keep on crashing on forge 1.20.1 even without any mods downloaded, i have the latest drivers (nvidia) and vanilla minecraft works perfectly fine for me logs: https://pastebin.com/5UR01yG9
    • Hello everyone, I'm making this post to seek help for my modded block, It's a special block called FrozenBlock supposed to take the place of an old block, then after a set amount of ticks, it's supposed to revert its Block State, Entity, data... to the old block like this :  The problem I have is that the system breaks when handling multi blocks (I tried some fix but none of them worked) :  The bug I have identified is that the function "setOldBlockFields" in the item's "setFrozenBlock" function gets called once for the 1st block of multiblock getting frozen (as it should), but gets called a second time BEFORE creating the first FrozenBlock with the data of the 1st block, hence giving the same data to the two FrozenBlock :   Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=head] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@73681674 BlockEntityData : id:"minecraft:bed",x:3,y:-60,z:-6} Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=3, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=2, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} here is the code inside my custom "freeze" item :    @Override     public @NotNull InteractionResult useOn(@NotNull UseOnContext pContext) {         if (!pContext.getLevel().isClientSide() && pContext.getHand() == InteractionHand.MAIN_HAND) {             BlockPos blockPos = pContext.getClickedPos();             BlockPos secondBlockPos = getMultiblockPos(blockPos, pContext.getLevel().getBlockState(blockPos));             if (secondBlockPos != null) {                 createFrozenBlock(pContext, secondBlockPos);             }             createFrozenBlock(pContext, blockPos);             return InteractionResult.SUCCESS;         }         return super.useOn(pContext);     }     public static void createFrozenBlock(UseOnContext pContext, BlockPos blockPos) {         BlockState oldState = pContext.getLevel().getBlockState(blockPos);         BlockEntity oldBlockEntity = oldState.hasBlockEntity() ? pContext.getLevel().getBlockEntity(blockPos) : null;         CompoundTag oldBlockEntityData = oldState.hasBlockEntity() ? oldBlockEntity.serializeNBT() : null;         if (oldBlockEntity != null) {             pContext.getLevel().removeBlockEntity(blockPos);         }         BlockState FrozenBlock = setFrozenBlock(oldState, oldBlockEntity, oldBlockEntityData);         pContext.getLevel().setBlockAndUpdate(blockPos, FrozenBlock);     }     public static BlockState setFrozenBlock(BlockState blockState, @Nullable BlockEntity blockEntity, @Nullable CompoundTag blockEntityData) {         BlockState FrozenBlock = BlockRegister.FROZEN_BLOCK.get().defaultBlockState();         ((FrozenBlock) FrozenBlock.getBlock()).setOldBlockFields(blockState, blockEntity, blockEntityData);         return FrozenBlock;     }  
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.